Control player dimensions by formatter.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

heshanlk’s picture

Patch attached.

heshanlk’s picture

Status: Active » Needs review
heshanlk’s picture

jec006’s picture

I like this idea, however, the issue I have is that youtube and vimeo videos + players aren't the same aspect ratio.

Youtube player + video by default is 349x560 while the vimeo one is 315x560 (i think this is mostly because of the differences in control schemes on the players). So having a single heightxwidth for a player will basically cause one or the other to be distorted. This was the original reason I pushed it off onto the handler functions and made the configuration by-provider.

I have moved all the configuration to the field instances, instead of it being in the variables table in a separate configuration. I also fixed the spacing issues you corrected in your patch.

I suppose an option would be to have settings-per-provider for each formatter - and specify based on which provider the video is from (similar to how the configuration is now). I don't know if this is preferable to field instance based height and width configuration - though it seems a bit purer.

jec006’s picture

Status: Needs review » Active

Marking active so we can continue this discussion. Portions of patches were used, while formatter changes weren't - the current patches will no longer apply.

jec006’s picture

Status: Active » Fixed

Check out 7.x-2.x which creates a nice video_style idea that will basically fulfill these needs.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.