The issue #1216210: Allow searchers to "opt out" of default node facets has been resolved in Facet API, which Search API could use to eliminate the need to strip out the default facets in it's hook_facetapi_facet_info_alter() implementation. All Search API would have to do is set the "include default facets" key to FALSE for all searcher definitions, and the hook_facetapi_facet_info_alter() implementation could be removed.

CommentFileSizeAuthor
#1 1304026--remove-hook_facetapi_facet_info_alter-workaround-1.patch2.1 KBdrunken monkey
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey commented
Category: feature » task
Status: Active » Needs review
FileSize
1304026--remove-hook_facetapi_facet_info_alter-workaround-1.patch2.1 KB

Ah, good news, thanks! The attached patch does that and works for me.

cpliakas’s picture

cpliakas CreditAttribution: cpliakas commented

Patch looks good to me, and definitely simplifies things a bit.

cpliakas’s picture

cpliakas CreditAttribution: cpliakas commented
Status: Needs review » Reviewed & tested by the community

Applied and tested, works as advertised.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey commented
Status: Reviewed & tested by the community » Fixed

Last commit for RC1! :D

cpliakas’s picture

cpliakas CreditAttribution: cpliakas commented

Exciting!!! This will be a significant moment for Drupal search. Well done.

Automatically closed -- issue fixed for 2 weeks with no activity.