Allow to toggle the drop shadow

Ok, I went ahead and did this. Please review.

That was a bad eol fail. Going again.

I don't get it, the admin_menu.test is indeed broken in the 3.0-rc1. I patched it up after finding #1146644: Admin Menu: Test: PHP 5.3 compability for parent::setUp callback, and now the tests on my local installation pass without a problem. I really don't know what to do with this.

I don't think a checkbox is the right approach. What exact issue are we trying to resolve?

The problem is the drop-shadow of the admin menu (interferes with themes some times). There are two ways to toggle something, checkbox or radio buttons. Checkboxes are used for the rest of the toggles in the Admin menu configuration so I went with that. That configuration setting is in reality a mere convenience setting since the same can be achieved by editing the admin_menu/admin_menu_toolbar/admin_menu_toolbar.css file.

What we need to know is when exactly the shadow interferes with a theme, and more importantly, why.

And then, the next best question is whether the shadow of the core Toolbar module also interferes with the theme.

Unless absolutely required, we should not add a configuration option for the shadow - that would be way too technical/special.

Putting it like that really turns this issue into a non substantial one.

I don't have serious background in usability issues nor I am a themer; but I can see the problem a themer might have with the drop-shadows found in both the Administration Toolbar module and the core Toolbar module. In such a specific user case, removing the drop-shadow is a no-brainer so that should not be a "burden" (aka extraneous configuration item) to the rest of the users of the module.

IMHO on these terms, this can be closed. DanielF should be given a chance/some time to enforce the case he is making.

Let's do #1022902: Align Better Toolbar style with core Toolbar style first and then see whether this is still required.

FWIW, #1683132: Extra 20px padding causes horizontal scrolling will make the shadow a lot smaller and less disturbing. Perhaps that might be sufficient already?

I just spent 5 minutes searching for how to disable the shadow and found this thread. As a designer I really like to see what the actual top of my page looks like. I don't want to have to login as anon to do that. It would be great to have an option to remove the shadow altogether as it lays itself on top of the design of the site.

Shouldn't we be using CSS for shadows now, instead of images?

Removing the #admin-menu-shadow div and adding this to #admin-menu-wrapper seems to work just as well, in Opera at least:

#admin-menu-wrapper
{
box-shadow: 0px 5px 10px rgba(0, 0, 0, 0.8);
}

Agreed. The shadow on this menu adds nothing to the usefulness and continually frustrates me when I am developing themes. I would love to be able to turn this off or have it permanently disabled.

Also agree the shadow adds nothing, interferes with appearance of the theme, and without the shadow provides a much cleaner look. Turning off the additional Administration menu Toolbar style solves this.

I am sorry for no reply until now.

There are many issues regarding this module admin_menu which is a bit difficult for us to follow up since some of the issues might be already outdated, or is already fixed by the module or any other modules or itself core which means that the problem might no longer need to be fixed.

We can see that the issue has been created for a few years ago, I hope it is okay for you that I am postponing the issue, and give you around two weeks. If you still face the problem, could you tell us the step by step when until you get the error message or what is frustrated you, and a list of modules you are using related to admin_menu and a screenshot that might help us? So it makes us easier to reproduce your issue.

However, after two weeks with no feedback - we will close this issue. So in case, you noticed it after the issue is closed, do not hesitate to reopen it like and fill information which is mentioned above.

So before giving us a feedback, do you mind to test it again with our latest 7.x-3.x-dev?

Thank you for understanding! :)

This issue has been automatically marked as closed because it has not had recent activity after the last post.

However, if you or someone is still facing the same issue as described to the issue, could you please to re-open the issue by changing the status of the issue, and add an explanation with more details which can help us to reproduce your situation.

Again, thank you for your contributions! :)