I just ran into this issue while working on a module that creates its own fields.

I was testing the module by adding new fields through the fields ui but the fields were not being saved. I couldn't figure out why until I realized that an error message was being output but it was being added to the "message okay" box instead of the "message error" box.

It looks like the errors being output through drupal_set_message should have a $type property added.

CommentFileSizeAuthor
#1 without patch.PNG43.24 KBDevin Carlson
#1 with patch.PNG44.74 KBDevin Carlson
#2 change-message-type-to-error-1308994-2.patch1.29 KBDevin Carlson
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Devin Carlson’s picture

Devin Carlson CreditAttribution: Devin Carlson commented
FileSize
with patch.PNG44.74 KB
without patch.PNG43.24 KB

Screenshots of what the errors look like currently and when set as warnings.

Devin Carlson’s picture

Devin Carlson CreditAttribution: Devin Carlson commented
Status: Active » Needs review
FileSize
change-message-type-to-error-1308994-2.patch1.29 KB

And a patch to add a type of 'error' to the messages I encountered.

droplet’s picture

droplet CreditAttribution: droplet commented
Status: Needs review » Reviewed & tested by the community
yoroy’s picture

yoroy CreditAttribution: yoroy commented
Issue tags: +Usability

Good catch, thanks for the screenshots.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to 7.x and 8.x. Nice catch.

Automatically closed -- issue fixed for 2 weeks with no activity.