Im getting this every time in the Checkout complete page

Notice: Undefined offset: 0 in commerce_google_analytics_ecommerce_js() (line 68 of C:\damp\www\es_gshop\sites\all\modules\commerce_google_analytics\commerce_google_analytics.module).

Any hint?

CommentFileSizeAuthor
#12 commerce_google_analytics-index_error-1349408-12.patch1.11 KBdouggreen
#11 commerce_google_analytics-index_error_with_unapplied_tax-1309408-11.patch1.15 KBzambrey
#6 commerce_google_analytics-index_error_with_unapplied_tax-1309408-5.patch891 byteswillieseabrook
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

brunorios1’s picture

brunorios1 CreditAttribution: brunorios1 commented
Priority: Normal » Major
urlaub’s picture

urlaub CreditAttribution: urlaub commented

I can confirm this bug under latest drupal dev 7.11 and drupal commerce 7.1.0

wayout’s picture

wayout CreditAttribution: wayout commented

Can also confirm I get this same message.

yannisc’s picture

yannisc CreditAttribution: yannisc commented

Same here. PHP 5.3

yannisc’s picture

yannisc CreditAttribution: yannisc commented

A quick solution to hide the notice is to change line 68 of commerce_google_analytics.module from:

$tax_sum += commerce_currency_amount_to_decimal($tax_component[0]['price']['amount'], $tax_component[0]['price']['currency_code']);

to:

$tax_sum += @commerce_currency_amount_to_decimal($tax_component[0]['price']['amount'], $tax_component[0]['price']['currency_code']);

willieseabrook’s picture

willieseabrook CreditAttribution: willieseabrook commented
Status: Active » Needs review
FileSize
commerce_google_analytics-index_error_with_unapplied_tax-1309408-5.patch891 bytes

This occurred for me when a tax rate is not applied. If the tax is not applied, then $tax_component[0]['price']['amount'] never exists.

The specific example on our site is that we ship to two countries - Australia and New Zealand.

Australian tax is applied to orders shipped to Australia
New Zealand tax applied to orders shipping to New Zealand

So for each order, one tax is not applied.

See my patch which adds a condition to first check whether the tax has been applied or not.

Cyberschorsch’s picture

Cyberschorsch
Primary language German
CreditAttribution: Cyberschorsch commented

This still needs to be reviewed please.

Cyberschorsch’s picture

Cyberschorsch
Primary language German
CreditAttribution: Cyberschorsch commented
Status: Needs review » Fixed

Commited in new 7.10 release

Cyberschorsch’s picture

Cyberschorsch
Primary language German
CreditAttribution: Cyberschorsch commented
Status: Fixed » Closed (fixed)
zambrey’s picture

zambrey CreditAttribution: zambrey commented
Status: Closed (fixed) » Reviewed & tested by the community

Looks like this fix wasn't commited
http://drupal.org/node/1136656/commits

Error still occurs in 7.x-1.0.

zambrey’s picture

zambrey CreditAttribution: zambrey commented
Priority: Major » Normal
Status: Reviewed & tested by the community » Needs review
FileSize
commerce_google_analytics-index_error_with_unapplied_tax-1309408-11.patch1.15 KB

Actually the patch needs to be rerolled.
Also removed some extra whitespaces.

douggreen’s picture

douggreen CreditAttribution: douggreen commented
Status: Needs review » Reviewed & tested by the community
FileSize
commerce_google_analytics-index_error-1349408-12.patch1.11 KB

Here is the same patch as above but without the extra spaces, and adds a period to the end of the comment (proper Drupal coding standards).

This patch (and the one above) works for me.

Cyberschorsch’s picture

Cyberschorsch
Primary language German
CreditAttribution: Cyberschorsch commented
Status: Reviewed & tested by the community » Fixed

Thanks ppl! Committed and pushed in the dev release for now.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.