i have found a little problem today: if u put video url with a space at the end, it doesnt work.
maybe u can add something like this:

$valid_url = str_replace(" ", "", $raw_url)

to make ir work properly???

thanks.

CommentFileSizeAuthor
#5 video_embed_field-url-whitespace-trim-1312326-5.patch852 byteswbobeirne
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jec006’s picture

jec006 CreditAttribution: jec006 commented

Sure, I can add a trim in there to fix this problem

jec006’s picture

jec006 CreditAttribution: jec006 commented

I fixed this here: http://drupal.org/commitlog/commit/25834/55bbc308ad9789bc927e39701d79e69...

You can check the project out from git to get the fix now, or wait for the dev version to rebuild.

dgastudio’s picture

dgastudio CreditAttribution: dgastudio commented
Status: Active » Closed (fixed)

thank u veru much

mototribe’s picture

mototribe CreditAttribution: mototribe commented
Version: 7.x-1.x-dev » 7.x-2.0-beta4
Category: feature » bug
Status: Closed (fixed) » Active

when there is a space at the beginning of the video it breaks the video (just shows the link with an invalid internal path).
Hope it's ok to open this old request rather than submitting a new one?

wbobeirne’s picture

wbobeirne CreditAttribution: wbobeirne commented
Status: Active » Needs review
FileSize
video_embed_field-url-whitespace-trim-1312326-5.patch852 bytes

Putting the trim in the validate function doesn't actually do anything, as $items are passed by value there. I've added it to hook_field_presave where the change will actually be reflected in what gets saved. Patch attached.

jec006’s picture

jec006 CreditAttribution: jec006 commented
Status: Needs review » Fixed

Committed here: http://drupal.org/commitlog/commit/25834/d55014e5cb71cb1d42a8ae81af26179...

Thanks

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.