In the HttpClientCurlDelegate class when executing a CURL request POST data is always added with curl_setopt($ch, CURLOPT_POSTFIELDS, $request->data);.

While a request without CURLOPT_POSTFIELDS would look like

> GET /api/ HTTP/1.1
User-Agent: Drupal (+http://drupal.org/)
Host: 192.168.0.8
Accept: application/xml

CURL automatically adds a Content-Length: 0 and a Content-Type: application/x-www-form-urlencoded header:

> GET /api/ HTTP/1.1
User-Agent: Drupal (+http://drupal.org/)
Host: 192.168.0.8
Accept: application/xml
Content-Length: 0
Content-Type: application/x-www-form-urlencoded
CommentFileSizeAuthor
#3 http_client-POST-data-is-always-added-to-a-CURL-request-1313374-38.patch1.42 KBsanduhrs
#2 curlopt_postfields-1313374-2.patch695 bytessanduhrs
#1 curlopt_postfields-1313374-1.patch695 bytessanduhrs
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sanduhrs’s picture

sanduhrs
he/him
Primary language German
Location 🇪🇺 Heidelberg, Germany, Europe
CreditAttribution: sanduhrs commented
Assigned: Unassigned » sanduhrs
Status: Active » Needs review
FileSize
curlopt_postfields-1313374-1.patch695 bytes

Adding post data only if not empty fixes the problem for me.
Patch attached, please review.

sanduhrs’s picture

sanduhrs
he/him
Primary language German
Location 🇪🇺 Heidelberg, Germany, Europe
CreditAttribution: sanduhrs commented
FileSize
curlopt_postfields-1313374-2.patch695 bytes

Well to more more accurate, we could also check f it's not NULL.
Patch attached.

sanduhrs’s picture

sanduhrs
he/him
Primary language German
Location 🇪🇺 Heidelberg, Germany, Europe
CreditAttribution: sanduhrs commented
FileSize
http_client-POST-data-is-always-added-to-a-CURL-request-1313374-38.patch1.42 KB

I'm trying to communicate with a BigBlueButton server which fails for GET requests because of the added POST data.
This behavior seems to be common.
It is even documented in drupal_http_request():

// Only add Content-Length if we actually have any content or if it is a POST
// or PUT request. Some non-standard servers get confused by Content-Length in
// at least HEAD/GET requests, and Squid always requires Content-Length in
// POST/PUT requests.

Added the above comment to the patch and adjusted the if statement accordingly.
Please review.

Hugo Wetterberg’s picture

Hugo Wetterberg CreditAttribution: Hugo Wetterberg commented
Status: Needs review » Fixed

Fixed in 7.x-2.4

Hugo Wetterberg’s picture

Hugo Wetterberg CreditAttribution: Hugo Wetterberg commented
Status: Fixed » Closed (fixed)