Sort "Edit components" SELECT alphabetically [#1313744]

The "Edit components" SELECT list on the create feature screen is out of alphabetical order because it's sorting on array keys that are sometimes different from their label (e.g. the "node" component is labeled "Content types"). See below:

The solution is simple. I'll attach a patch immediately.

Comment	File	Size	Author
#8	features-1313744-8.patch	1.16 KB	TravisCarden
#8
#3	features-1313744-3.patch	868 bytes	TravisCarden
#3
#1	features-1313744-1.patch	858 bytes	TravisCarden
#1
	features-components-select.jpg	77.27 KB	TravisCarden

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

TravisCarden CreditAttribution: TravisCarden commented 18 October 2011 at 20:36

Assigned:	TravisCarden	» Unassigned
Status:	Active	» Needs review

File	Size
features-1313744-1.patch	858 bytes

Comment #2

hefox CreditAttribution: hefox commented 22 October 2011 at 23:11

Version:	6.x-1.x-dev	» 7.x-1.x-dev
Status:	Needs review	» Needs work

applies cleaning to 7.x but

Parse error: syntax error, unexpected T_FUNCTION in [..]/features.admin.inc on line 70

Comment #3

TravisCarden CreditAttribution: TravisCarden commented 23 October 2011 at 07:19

File	Size
features-1313744-3.patch	868 bytes

Aw, nuts! PHP doesn't support anonymous functions before version 5.3. Well, here's a new patch accounting for that, rolled against 7.x-1.x-dev.

Comment #4

TravisCarden CreditAttribution: TravisCarden commented 3 November 2011 at 13:20

Status:

Needs work

» Needs review

Comment #5

febbraro CreditAttribution: febbraro commented 3 November 2011 at 15:59

Status:

Needs review

» Needs work

+++ b/features.admin.incundefined
@@ -67,7 +67,10 @@ function features_export_form($form, $form_state, $feature = NULL) {
+  function compare($a, $b) {

All functions in PHP have global scope so this needs to be better namespaced and should also be moved external to the features_export_form function.