Hi

after updating module to 6.x-2.0 dev i've this error :

PHP Parse error:  syntax error, unexpected '@', expecting ',' or ')' in /var/www/drupal6/sites/all/modules/taxonomy_xml/taxonomy_xml.module on line 1821
Drush command terminated abnormally due to an unrecoverable error.                                    [error]
Error: syntax error, unexpected '@', expecting ',' or ')' in
/var/www/drupal6/sites/all/modules/taxonomy_xml/taxonomy_xml.module, line 1821

and website is down...hope this help to fix this

Comments

dman’s picture

Status: Active » Fixed

Damn, you got caught by that? sorry, was a bad commit in there for a few hours.
I was running the various branches though code tidy-up/layout cleaner to get them more similar for cross-patching and things - now that D7 version is workable but D6 got a few fixes in the meantime and the code - thanks to the conversion done a few months ago is NOT regognisible line-by-line .... anyway pain.

So at 4:00 AM last night a few gremlins crept in. Seems the Grammar parser that was supposed to just be making whitespace changes decided to put the @ inside a function not outside it. I caught it when testing the 1.x branch, but must have missed that the same thing had happened to the 2.x at a similar time.

ANYWAY. Bad git, bad grammar parser, bad me for pushing it up to d.o without fully re-testing it all .. on all versions. :-(
Anyway, I've re-checked in code that does not have that bug. Try again from a clean checkout!

dman’s picture

PS, good error report - I was able to immediately recognize exactly what it was !

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.