Media browser library fake submit handler

There is a problem with the fake submit handler in the media browser (views) library.

If you don't select anything it alerts you then loads the homepage in the iframe due to the click event not being cancelled. It also adds the click handler onto the fake buttons as many times as you click around in the library. So if you click through a few pages n times without selecting anything and click submit it actually executes the submit handler n+1 times.

The event handler duplication can be fixed with

  $('a.button.fake-submit', this).once().bind('click', Drupal.media.browser.submit);
  $('a.button.fake-cancel', this).once().bind('click', Drupal.media.browser.submit);

The event bubbling can be fixed with a return false .

Drupal.media.browser.submit = function () {
  // @see Drupal.media.browser.validateButtons().
  var buttons = $(parent.window.document.body).find('#mediaBrowser').parent('.ui-dialog').find('.ui-dialog-buttonpane button');
  if ($(this).hasClass('fake-cancel')) {
    buttons[1].click();
  }
  else {
    buttons[0].click();
  }
  // return false to prevert the default anchor location
  return false;
}