assertTaxonomyPage in node.test has no documentation.

#16 1318316-d7-16.patch1.7 KBxjm
PASSED: [[SimpleTest]]: [MySQL] 37,045 pass(es).
[ View ]
#11 1318316-11.patch1.72 KBxjm
PASSED: [[SimpleTest]]: [MySQL] 33,983 pass(es).
[ View ]
#11 interdiff.txt786 bytesxjm
#6 1318316-5.patch1.55 KBxjm
PASSED: [[SimpleTest]]: [MySQL] 33,982 pass(es).
[ View ]


Priority:Major» Normal

Methods in tests missing docs is the exact opposite of a major bug.

Seems to me if the tests with which you check the code is working themselves are not understandable, we have a problem multiplied.

Component:node.module» taxonomy.module
Category:bug» task
Priority:Normal» Major

That's still not a functional bug, but I'll split the difference and do this?

Assigned:Unassigned» xjm

Status:Active» Needs review

Added a doclock. I also took the liberty of renaming $super to $is_admin. (Even though it was $super.) :)

new1.55 KB
PASSED: [[SimpleTest]]: [MySQL] 33,982 pass(es).
[ View ]

How about I upload the patch.

Component:taxonomy.module» documentation

Really this is docs more than taxonomy.module itself.

Status:Needs review» Reviewed & tested by the community

Test bot passes, docs look good, and the renamed param is definitely a good thing.

The patch is super!

Status:Reviewed & tested by the community» Needs review

// Non-superusers on the private page can only see their own nodes.

Should this be "non-admins" now the variable is changed? Super user is usually uid 1 for us.

new786 bytes
new1.72 KB
PASSED: [[SimpleTest]]: [MySQL] 33,983 pass(es).
[ View ]

With comment correction. I double-checked and this eliminates everything super from the file. Sorry node.test.

Status:Needs review» Needs work

The last submitted patch, 1318316-11.patch, failed testing.

Status:Needs work» Needs review

Bot issue.

Status:Needs review» Reviewed & tested by the community

Looks good to me.

Version:8.x-dev» 7.x-dev
Status:Reviewed & tested by the community» Patch (to be ported)

Committed/pushed to 8.x, thanks!

Seems like this could be backported.

Status:Patch (to be ported)» Reviewed & tested by the community
Issue tags:+needs backport to D7
new1.7 KB
PASSED: [[SimpleTest]]: [MySQL] 37,045 pass(es).
[ View ]

Straight reroll for D7.

I also switched the backport tag to what (I think?) is the standard one, at least from (Maybe someone with database access should re-tag all nodes for the former with the latter and then delete it.)

Status:Reviewed & tested by the community» Fixed

Committed and pushed to 7.x. Thanks!

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Assigned:xjm» Unassigned