Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 UTC on 18 March 2024, to get $100 off your ticket.
i made the upgrade to the last dev (somthing done last week) and the editablefields for price field stop working.
1!--form-item-commerce_price_1--0-->
this is what it displays instead of the price editable field.
the view it's content view with product reference relationship
Comment | File | Size | Author |
---|---|---|---|
#36 | editablefields-1327458-36.patch | 563 bytes | Dane Powell |
Comments
Comment #1
rszrama CreditAttribution: rszrama commentedI don't see how this can be a problem w/ Commerce. Nothing has changed in the Price field form elements in some time, afaik.
Comment #2
vasikebecause it worked and the drupal commerce was the upgraded one.
Comment #3
itserich CreditAttribution: itserich commentedSimilar error when upgrading to the latest Views Development version.
Reverted to a prior Views Development version and the error is gone.
In my case it is a normal View consisting of a regular Text Field inside a regular Content Type. Drupal Commerce is installed but not related to this error in my case, I think.
Comment #4
rszrama CreditAttribution: rszrama commented@vasike - as I said above, nothing has changed with the Price field form lately. Are you sure you didn't update anything else at the same time? Drupal Commerce is only tested to work against the latest actual release (i.e. non-dev version) of Views. But I'm not sure why that would affect editablefields.
Comment #5
latulipeblanche CreditAttribution: latulipeblanche commentedI installed "Editablefields" (7.x-1.0-alpha1) on Drupal Commerce (7.x-1.0).
I got a problem with the calculation of the total price of an order.
A product costs 1€.
In the View of all the products (where I use "Editablefields" for price) I changed the price to 1.10€.
The price changed in the Product-Display.
I changed the price back to 1€. The price changed again in the Product-Display to 1€, so OK.
But .....
When a client bought that product, the Total Price of the order was 2.10€ higher than the real price.
( 5 x 1€ was 7.10€ and not 5€ )
Comment #6
vasike@ rszrama : my fault. it was more a hunch.
it seems that @itserich is more accurate
Comment #7
GiorgosKmarked my issue as duplicate [#] and chimming in
editablefields stopped working altogether after update of views to latest dev and ctools
can anybody else confirm this ?
Comment #8
GiorgosKshould this be posted in views ?
Comment #9
GiorgosKmeant to change title
Comment #10
Yuri CreditAttribution: Yuri commentedYes I confirm that editablefields is not working any more with the latest Views dev version.
Critial.
Comment #11
GiorgosKYuri we are working with dev version and its not something that breaks a system unusable so it can't be critical (read priority link) but I will try at major
still we don't know if this should be posted to views
maintainer should comment on that
Comment #12
AABoyles CreditAttribution: AABoyles commentedSame problem, can confirm that it's an issue between the current views dev version and editablefields (i.e. I'm not running Commerce).
Comment #13
Vagabondo CreditAttribution: Vagabondo commentedSame problem, but then I did a test.
I tried to use Editablefields in Panels, without using Views. Fields look good there, but when I tried to change the value, I got this pop-up alert:
Then probably the conflict is first of all with the latest ctools. Hope this can help.
Edit: In spite of this error message, the new field value entered with editable fields was saved correctly
Comment #14
AABoyles CreditAttribution: AABoyles commentedI don't think it's a ctools problem. I got the issue after updating views, and I haven't updated ctools. I think that error is something else entirely (I believe it comes from using editablefields with Panels). See http://drupal.org/node/1206656#comment-5214648 for more background on that.
Comment #15
Yuri CreditAttribution: Yuri commented@14: I'm having this issue without Panels installed.
Comment #16
johnvSame as #15: I'm having this issue without Panels installed.
Comment #17
johnvI just copied the code from the 'normal' case to the 'views_view' case, and it seems to work fine:
[EDIT] when 'click to edit' is not set.
Comment #18
itserich CreditAttribution: itserich commentedComment #19
itserich CreditAttribution: itserich commentedComment #20
Yuri CreditAttribution: Yuri commentedapplying #17 (and flush cache) throws exactly same ajax error as in #13 for 'click to edit' fields.
The field looks as it should without clicking it, but still not editable.
Comment #21
ShadowMonster CreditAttribution: ShadowMonster commentedsubscribe
Comment #22
GiorgosK@shadowmonster
there is a follow button on top right use that instead
Comment #23
AABoyles CreditAttribution: AABoyles commentedI'm not using Click-to-Edit, and #17 worked to make the interface come back, but it also triggered the same error as #13.
Comment #24
johnvAABoyles, #13 and #14 are off-topic, (as you stated yourself ;-) ) see: #1206656: Error on Node view page: Argument 1 passed to drupal_array_get_nested_value()
Comment #25
AABoyles CreditAttribution: AABoyles commentedPerhaps I should clarify: I was just affirming that the hack in #17 fixes this issue for a subset of EditableFields users and creates a new one for those who use this approach.
Comment #26
ShadowMonster CreditAttribution: ShadowMonster commented@GiorgosK
yep - sorry old habbit
Comment #27
sun-fire CreditAttribution: sun-fire commentedThe same error. In my case it was happend with term reference field.
Comment #28
hampshire CreditAttribution: hampshire commentedSame problem trying this with VBO on a fresh install with the newest versions of everything. I am not using Panels or Commerce. Does this module work for anyone who's install is up to date?
Comment #29
AndrzejG CreditAttribution: AndrzejG commentedI also have this problem, please see http://drupal.org/node/1345886.
Some details there.
Comment #30
Dane Powell CreditAttribution: Dane Powell commentedIt sounds like the only progress towards a solution so far is #17, and it's incomplete...
Also, I don't see why this is not critical- it's effectively a security issue, since it blocks the upgrade to a secure release of Views.
Comment #31
AndrzejG CreditAttribution: AndrzejG commentedProbably now this is only with newest Views, not CTools.
I have dev version of CTools from Nov. 16th. Now, returned to critical Views RC1, and Editable fields are working.
Comment #32
Dane Powell CreditAttribution: Dane Powell commentedPlease don't change the priority/status without a good explanation for why...
Comment #33
AndrzejG CreditAttribution: AndrzejG commentedI didn't change. And don't know who.
Comment #34
j_ten_man CreditAttribution: j_ten_man commentedHere is how I fixed the issue:
Editable fields line 232-234:
For someone who knows Views better than I do, the issue was that in views_handler_field_field.inc the set_items function is expecting this to be an array as it sets a '#access' value which is why it was displaying
1!--form-item-commerce_price_1--0-->
instead of<!--form-item-commerce_price_1--0-->
. Line 778 of the module. Hopefully it works for others.Comment #35
Vagabondo CreditAttribution: Vagabondo commented#34 Works perfectly for me
Thank you! :-)
Comment #36
Dane Powell CreditAttribution: Dane Powell commentedHere's a patch based on #34...
Comment #37
badsit CreditAttribution: badsit commented#34 and patch from #36 works for me too..
thanks!
Comment #38
johnvsame for me => RTBC
Comment #39
Damien Tournoud CreditAttribution: Damien Tournoud commentedMerged into 7.x-1.x. Thanks for the patch, guys!
I'm releasing alpha2 with this patch.