The following warnings appeared after updating to D7.9 from D7.8 and only if the file field is attached to a field collection -- I debated adding the issue to the contrib module but the error is being reported by the file module and error/warning was not present in D7.8.

Full Error Message:

Warning: Invalid argument supplied for foreach() in file_field_widget_submit() (line 753 of F:\web4\d7test2\modules\file\file.field.inc).
Warning: array_values() [function.array-values]: The argument should be an array in file_field_widget_submit() (line 760 of F:\web4\d7test2\modules\file\file.field.inc).

Does not occur if you have the file field attached straight to a content type - appears to only occur if attached to a field collection. The # of values for both the field collection and the file field were set to 1 - single instance only.

Does not occur if you add the file and submit the form - only if you use the upload button and form is rebuilt.

Occurs when adding new node or editing existing node.

I could upload a patch that adds logic to test for a valid array before the foreach loop at line 753 but was not sure if there is a deeper issue here - please advise as I'd be pleased to submit my first core patch if it's that easy :)

Files: 
CommentFileSizeAuthor
#65 error_messages.png61.73 KBweri
#46 issue_1329856.patch853 bytesserbanbjd
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch issue_1329856_2.patch. This may be a -p0 (old style) patch, which is no longer supported by the testbots.
[ View ]
#38 issue_1329856_1.patch629 bytesjec006
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to create dependency directory.
[ View ]
#34 issue_1329856.patch651 bytesMorpheus80ta
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch issue_1329856_0.patch. This may be a -p0 (old style) patch, which is no longer supported by the testbots.
[ View ]
#11 issue_1329856.patch1.4 KBblainelang
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch issue_1329856.patch. This may be a -p0 (old style) patch, which is no longer supported by the testbots.
[ View ]

Comments

subscribe

I still think this is a field_collection issue passing the wrong arguments to the function

Project:Drupal core» Field collection
Version:7.9» 7.x-1.x-dev
Component:field system» Code

If the widget works correctly in the context of core then it has to be the contrib menu that is at fault, moving to the appropriate queue

It seems the drupal_array_get_nested_value is failing to get the submitted values. This is returning NULL which is hanging everything up (line 752 of modules/file/file.field.inc):

$submitted_values = drupal_array_get_nested_value($form_state['values'], array_slice($button['#array_parents'], 0, -2));

I'm not sure how drupal_array_get_nested_value works, but it seems like the nested parent keys don't exist.

For me, $form_state['values'] was:

array ( 'field_product_images_und_0_field_product_image_und_1_upload_button' => 'Upload', )

And the second argument array_slice($button['#array_parents'], 0, -2) was:

array ( 0 => 'field_product_images', 1 => 'und', 2 => 0, 3 => 'field_product_image', 4 => 'und', )

Is $form_state['values'] not being set correctly?

Project:Field collection» Drupal core
Version:7.x-1.x-dev» 7.9
Component:Code» field system

I don't have field collection module and I have the same problem.

I have a custom module to group some fields into fieldsets, I assume field collection does something similar, but I think its some kind of change in Form API in D7.9 that breaks this functionallity and possibly others.

Project:Drupal core» Field collection
Version:7.9» 7.x-1.x-dev
Component:field system» Code

I am seeing the same problem when upgrading to 7.9. There appears to be a mismatch in the data going into the drupal_array_get_nested_value on line 752 file.field.inc.

The form_state values are...

$form_state values at file.field.inc 752
Array
(
   [my_field_image] => Array(
[und] => Array(
[0] => Array(
[_weight] => 0
[fid] => 629
[display] => 1
[description] =>
[upload_button] => Upload
[remove_button] => Remove
[upload] =>
[width] => 800
[height] => 600
[alt] =>
[title] =>
)
)
)
   [my_field_image_und_0_upload_button] => Upload
)

and the $button['#array_parents'] values are...

$button['#array_parents'] values at file.field.inc 752
Array(
[0] => myelement
[1] => S4
[2] => my_field_image
[3] => und
[4] => 0
[5] => upload_button
)

I am not very familiar with the drupal_array_get_nested_value() function, but the second parameter should be an array of parent keys. The slice removes the last two keys to provide the parent keys. BUT it looks like that does not match what is in the $form_state['values'] array. So either the $form_state['values'] or the $form_state['triggering_element'] array is being incorrectly set. The $form_state['values'] look like they have been flatened.

By fixingup the $button['#array_parents'] to accurately match up with the $form_state['values'] as a quick work-around - the errors messages went away and things seem to be working.

Hope this helps towards a fix!

subscribe

Perhaps I'm a little dense, but I can't quite work out what you've done and where. I can't find any code like that in my file.field.inc file. Could you expand on your solution a little bit? Maybe a quick patch?

Thanks!

I think @blainelang has a patch coming.

The code you will see at file.field.inc /modules/file/file.field.inc 752 is

  $submitted_values = drupal_array_get_nested_value($form_state['values'],array_slice($button['#array_parents'], 0, -2));

As a TEMPORARY fix that worked for me, I replaced the second parameter of drupal_array_get_nested_value with a different way of calculating the parent keys. As @blainelang pointed out, changes here may have unwelcome effects elsewhere - but it worked for me.

$submitted_values = drupal_array_get_nested_value($form_state['values'], array_slice(array_keys($form_state['values']), 0, -1));

I'm having the same problem but my $form_state['values'} looks like an imploded array:

Array ( [profile_designer_field_designs_und_0_field_image1_und_0_upload_button] => Upload not a flattend one.

what could cause this?

Idan

Status:Active» Needs review
StatusFileSize
new1.4 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch issue_1329856.patch. This may be a -p0 (old style) patch, which is no longer supported by the testbots.
[ View ]

Attached is a patch that adds a test for a valid array before trying to process $submitted_values. This removes the warnings in my use-case and the file widget uploaded the file successfully.

Status:Needs review» Needs work

That patch is against core, but this issue is still against field_collection.

@tim: understand, but I submitted this issue against core and did not change it to field_collection. This issue is appearing in other modules as noted by the other comments.

Project:Field collection» Drupal core
Version:7.x-1.x-dev» 8.x-dev
Component:Code» field system
Status:Needs work» Needs review
Issue tags:+needs backport to D7

I have tried the patch in #11 but experienced an issue. With the patch applied I am unable to "remove" an image. Anyone else seeing this?

I've applied and still getting the result in #10

Priority:Normal» Major

I've had to revert to my last version (7.7). The 7.9 version completely breaks image processing ( and presumably other sites that may rely on file uploads ) - including sites that have been previously working well. The problem does not show in a simple clean install however. This is show-stopper for anything other than the most basic site and my concern is that this bug may not get fixed before the next release. I have therefore upped the priority.

Status:Needs review» Needs work
Issue tags:+Needs tests

This was last changed in #1059268: Files are lost when adding multiple files to multiple file fields at the same time.

If that patch introduced a regression, then we need a test to catch that regression.

The patch here is doing unnecessary checks for count($array) -> 0. If an array is empty, then foreaching over it does nothing.

How are we ending up with an invalid array there? Is that a bug in field collection?

Confirming that the patch provided in #11 doesn't help unfortunately. I'm using it with the latest version of D7.9 and the Field Collection 7.x-1.0-beta2.

The patch in #11 has solved any issues I was experiencing.

I'm currently using Field Collection 7.x-1.x-dev and core 7.9.

im having the same problem, found it in both 7.8 and 7.9 core

Confirming #20: it does work with Field Collection 7.x-1.x-dev (13 nov 2011).

Minor remark: it doesn't automatically upload the selected image when you hit "Add item" button. You either have to hit the "Upload" button right after you selected the file, or immediately save the node.

latest field collection patch doesn't work,

I get this message:

Warning: array_values() [function.array-values]: The argument should be an array ב-file_field_widget_submit() (\modules\file\file.field.inc).

Idan

Idan, what version of Drupal and Field Collection are you using? Note that it's working on the configuration mentionned in #20.

7.9 and latest dev (from today).

$submitted_values is an empty array when dsm'ing right before $submitted_values = array_values($submitted_values);
Image uploads ok, if I hide the warnings, it works fine.

Just as a heads-up. Whatever is happening in Field Collection is certainly just a symptom. I am experiencing these problems and do not have Field Collection installed.

It's a bit unclear to me from this thread where the issue exists (core vs. field_collection). I was experiencing this issue with drupal-7.9 and field_collection-7.x-1.0-beta2. Updating field_collection to 1.x-dev resolved the issue for me.

So, is this still an active issue? If so, is it a core issue or should it be a field_collection resolved/patched issue?

I am still experiencing these same warning using Image fields in a field collection - the image / file upload does work, however, these warnings appear.

Perhaps the submit handler is getting called twice? Will investigate further.

versions are:
7.9 for drupal core
7.x-1.x-dev (2011-Nov-15) for field_collections

Have you used the patch in #11?

No, I did not use the patch, was simply stating that with the latest version of the module, this issue still exists. (edit: in re scott)

Ok. Again, for me field_collection dev (Nov 15) along with drupal 7.9 resolved the issue without the patch. That, of course, doesn't mean it's fixed for everyone. Actually, after reading back through the issue, I'm afraid to test it again lest my issue return.

Project:Drupal core» Field collection
Version:8.x-dev» 7.x-1.x-dev
Component:field system» Code

Moving back to field collection as this does not seem like a core issue

The patch in #11 has solved the issues with Field Collection 7.x-1.x-dev and core 7.9.
but still having the problem in #22 , does anyone have a solution for this one?

Version:7.x-1.x-dev» 7.x-1.0-beta2
StatusFileSize
new651 bytes
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch issue_1329856_0.patch. This may be a -p0 (old style) patch, which is no longer supported by the testbots.
[ View ]

The problem it's on the row 984 in field_collection.module. In the hook field_collection_field_widget_embed_validate if submitted data pass validations the content of form_state['values'][] is replaced with the entity, so it is saved with the host entity via hook_field_presave(). In the next pass the form submit handlers don't find the value in form_state becouse this is overwritten.
The solution is replace
if ($form_state['submitted'] && !form_get_errors() ) {

with
if ($form_state['submitted'] && !form_get_errors() && $form_state['clicked_button']['#name'] == 'op') {

Drupal core: 7.9
Field Collection 7.x-1-0-beta2

#34 worked for me.

Drupal core: 7.9
Field collections: 7.x-1.x-dev

Status:Needs work» Needs review

#34 worked for me.

Drupal core: 7.9
Field collections: 7.x-1.x-dev

Status:Needs review» Needs work

The last submitted patch, issue_1329856.patch, failed testing.

Version:7.x-1.0-beta2» 7.x-1.x-dev
StatusFileSize
new629 bytes
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to create dependency directory.
[ View ]

Awesome, thank you so much Morpheus80ta

I simply rerolled the fix in #34 (which also worked for me) and made it apply against dev and be from the module root so it will hopefully pass testing and we can get it applied.

This fixed the errors that were showing on image upload for me

Status:Needs work» Needs review

marking for test scripts

Status:Needs review» Needs work

The patch in #38 solves the original problem on entities which only have image/file fields which are contained in field collections. However a new error message is invoked if your entity has a regular (not in a field collection) file/image field AND a file/image field contained in a field collection. See skitch for clarification of field/field collection config.

Error msg:
Notice: Undefined index: display_field in file_field_widget_value() (line 578 of .../www/modules/file/file.field.inc)

https://skitch.com/mrsimonelliott/gqdau/field-collection-issue

Patch #38 doesn't work if you use the "upload" button of the image widget before you submit the node.

Patch #38 solved the problem with field_collection 7.x-1.0-beta2, thank you very much=)

Same here. Patch #38 solved the problem.

#38 worked, but still having the problem described in #40

Patch from #38 worked for me nicely. I am only not very happy with using

$form_state['clicked_button']['#name'] == 'op'

for testing is form is really submitted or we are just in some ajax event, but I was not able to find some better condition for this check. Note that this condition will be true also if user hit preview or delete button - not sure should this code execute on this two submit events.

I then tried different combination of #40 - regular image field and image field in field collection, but I was not able to get error message from #40. I am using D7.10 and latest field_collection dev version.

Additional note, while testing I found one more bug, if you add image in collection and try to hit preview you will get new error message

Notice: Undefined index: uri in theme_image_formatter() (line 579 of /home/ivica/moje/lamp/www/local.inyoga.rs/modules/image/image.field.inc).

and image from field collection will not be rendered. But this is completely unrelated problem with this issue and is definitely not a major bug.

StatusFileSize
new853 bytes
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch issue_1329856_2.patch. This may be a -p0 (old style) patch, which is no longer supported by the testbots.
[ View ]

this fixed the warnings in file_field_widget_submit. i was able to upload/remove file in field collection.

this is my first patch upload, so be gentle if i actually screwed things.

Status:Needs work» Needs review

Status:Needs review» Needs work

The last submitted patch, issue_1329856.patch, failed testing.

Priority:Major» Normal
Status:Needs work» Active
Issue tags:-Needs tests, -needs backport to D7

Those patches are against core. Please set to needs review once there is a patch for this module.

Does 7.x-1.0-beta3 vesrion contain a fix for these warnings? I removed and did a fresh install of the module but the warnings persist. I have a simple field collection containing an image field and a text field. When uploading an image I keep getting

  • Warning: Invalid argument supplied for foreach() in file_field_widget_submit() (line 754 of C:\xampp\htdocs\sitename\modules\file\file.field.inc).
  • Warning: array_values() expects parameter 1 to be array, null given in file_field_widget_submit() (line 761 of C:\xampp\htdocs\sitename\modules\file\file.field.inc).

Getting the same behaviour as in #50. Using version 7.x-1.0-beta3

Nothing here has been committed. Reports about patches are where individuals have applied them to test.

This error occurs in Taxonomy Manager if you add an image field to a vocabulary. So it is not an issue solely linked to field_collection. It occurs if you try to upload the image or remove the image using the Upload and Remove buttons. So it may be linked to how these button actions are defined in the image widget.

It does not happen if you select the image using the Browse button and then click the Save Changes button.

It does not happen when using the core taxonomy editing form.

Status:Needs review» Needs work

Please go back to looking a the patch in #38 It is against field_collections. Apparently its not 100% but is a start. Getting sidetracked by patching core again seems less than ideal.

Status:Active» Needs review

#38: issue_1329856_1.patch queued for re-testing.

Status:Needs work» Needs review

No use in retesting something that has no tests. Maybe writing a test? What is $form_state['clicked_button']['#name'] when this breaks?

Sorry - Was just re-queueing to shift attention back to fixing field collections.

It appears that the validate function gets run when the upload button is clicked. Data is missing from the form at this stage in the form_state, it only includes very specific data for the submission of the file/image field. It seems like there should be some better clue to handle the submission differently ... but I don't see it.

The value for clicked button will be something like: field_collection_gallery_und_0_field_main_image_und_0_upload_button in this situation.

I don't think this patch is 100%. It seems like there are some remaining issues that need work.

#38 manually patched against 7.x-1.0-beta3 works for me. I have a normal field and fields inside collections in the same entity, like #40, but no issues.

Status:Needs review» Needs work

Either needs some good docs, a test, or both.

Ignore, my issue was due to a custom module.

Would someone be able/willing to summarize what could be done for this error? I'm seeing a lot of patches, but I'm not sure which one(s) to use to fix this error. Could anyone advise? I'm on the latest core 7.12 and 7.x-1.0-beta3 of Field Collection. Should I install the dev version of Field Collection? Try one of the patches, perhaps #38?

Warning:
Am a total Drupal NOOB Dev... hope my input helps!

Setup:
Drupal 7.12, Field Collection 7.x-1.0-beta3

Error:
Warning: Invalid argument supplied for foreach() in file_field_widget_submit() (line 760 of /mnt/www/docroot/modules/file/file.field.inc).
Warning: array_values() [function.array-values]: The argument should be an array in file_field_widget_submit() (line 767 of /mnt/www/docroot/modules/file/file.field.inc).

Error occurs after uploading using the Upload btn in an image field.

File uploads correctly and on saving the node using the Field Collection, the image is viewable correctly.

Would be great to not have the warning though. I see that patch #38 has passed. Am gonna try applying it and will edit this comment with my results.

Subscribed :o)

Thanks to the maintainers of the module!

________________________________________________________________________________

One further note that might be helpful. The Warning is not appearing on my local development environment (WAMP 2.1, PHP error_reporting = E_ALL | E_STRICT) but on my remote integration environment (hosted by Acquia).
________________________________________________________________________________

UPDATE:
Applied the patch and it has corrected the error.

Thanks to the patch contributor!

Version:7.x-1.x-dev» 7.x-1.0-beta3

Set up: D7.12, Field collection 7.x-1.0-beta3

I'm having the same issue as discussed above:
Warning: Invalid argument supplied for foreach() in file_field_widget_submit() (line 765 of D:\Websites\testsite\modules\file\file.field.inc).
Warning: array_values() expects parameter 1 to be array, null given in file_field_widget_submit() (line 772 of D:\Websites\testsite\modules\file\file.field.inc).

I tried the patch but unfortunately did not resolve the issue.

#38 worked for me with 7.x-1.0-beta3 field collection and Drupal 7.12.

I have to say tha i Had the same error than #62

StatusFileSize
new61.73 KB

I believe this is a core file/file-widget issue and not an field collection issue. I got this error messages also when i add a nested file field to a form (attaching entity fields to a existing form). The error also occurs when i try to remove the image.

applied patch in #46 but still get the warning message.
I added an extra condition to check the count of the submitted_values array.
The error disappeared.

This probably isn't the right solution, but it works...

if (count($submitted_values)) {
foreach ($submitted_values as $delta => $submitted_value) {
if (!$submitted_value['fid']) {
unset($submitted_values[$delta]);
}
}
// Re-index deltas after removing empty items.
$submitted_values = array_values($submitted_values);
}

I hope a patch for this come out soon, I'm experiencing the same problems and although my images get rendered the attributes alt and title are not and I totally need them for this project.

Did some debugging on this: http://pastie.org/3541728

Looks like the issue is that Field Collection isn't setting up the proper $form_state['values'] .

Just want to reference #1468686: file_field_widget_submit(), file.field.inc using the wrong parent key that is likely related and seems to use the method employed in #66.

Status:Needs work» Needs review

Status:Needs review» Needs work

There have been no new patches since #59.

Patch at #38 seems to have fixed the problem for me

for me also patch at #38 fixed the problem, thanks

Patch at #38 fixed the problem for me too. Thank you very much.

Status:Needs work» Needs review

#38: issue_1329856_1.patch queued for re-testing.

#38 issue_1329856_1.patch is worked for me. thx!

#38 issue_1329856_1.patch is worked for me 2...

THANKSSSSSSS

Status:Needs review» Reviewed & tested by the community

Patch from #38 eliminated the error.

Status:Reviewed & tested by the community» Closed (duplicate)

As was suggested in #66 and pointed out in #69, #1468686-8: file_field_widget_submit(), file.field.inc using the wrong parent key fixes this issue.

Status:Closed (duplicate)» Active

Sorry for reopening that bug Tim, but i've some extra information about it.
I'm using field collection and File Field Sources. To allow the user to select an image through IMCE (to avoid reuploading several time the same image).

I was facing an issue where i had a field collection containing an image field.
It worked fine for the inital image selection. However if i picked an image, removed it, and tried to pick another through imce, nothing would happend. If i tried to repick an image through the default upload i would get the error messages that were posted above.

As you suggested i applied the patch from #1468686-8: Array error in file_field_widget_submit(), file.field.inc, which fixed the error message and made the default upload work after an image was removed.
BUT it still didn't work when i tried to use IMCE after an image was removed. Applying the patch from 38 fixed that problem though.

So you might want to commit it to field collection.

Confirming patch #38 fixed the issue for me too, and from the edge case explained above, it sounds like a valid thing to commit.

Status:Active» Needs review

#38: issue_1329856_1.patch queued for re-testing.

The patch fixes the error but wenn you have a image field in this content-type the image field upload fails.

Patch #38 fixes the errors for me even for images with beta4 version ...

Same for me : patch #38 fixes the errors with beta4
thanks!
-p-

#38 works for me too... Thanks.

Status:Needs review» Reviewed & tested by the community

Status:Reviewed & tested by the community» Fixed

Thank you!

Thanks!

I did not want to hack modules, but I can't see another way still(

And how do you think, tim.plunkett, will this bug be corrected in the next version of Field collection?

This is already in the current dev release. It will therefore be in the next tagged release as well.

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Status:Closed (fixed)» Needs work

- if ($form_state['submitted'] && !form_get_errors()) {
+ if ($form_state['submitted'] && !form_get_errors() && $form_state['clicked_button']['#name'] == 'op') {

hm, that assumes the button has to be named 'op' - or it would skip validation. If an entity form has a different named button, validation would be skipped - *ouch*. Let's better revert this and a better solution.

I'm not sure which button click we have to void validating on, but the correct fix must be something else.

As this his possibly security implications I've reverted it. Let's try to come up with a proper solution.

Are the remaining problems related to images only? Then, the image related issue might have a solution: http://drupal.org/node/1545584#comment-6148300

Confirming Patch #38 fixed errors with 7.x-1.0-beta4

With Drupal 7.15 and Field collection 7.x-1.0-beta4 ...

I've created a Field Collection with a generic file upload and a text field. When I upload a file, I'm getting these errors:

Warning: Invalid argument supplied for foreach() in file_field_widget_submit() (line 756 of /data/disk/b3share/static/ncjw-002/modules/file/file.field.inc).
Warning: array_values() expects parameter 1 to be array, null given in file_field_widget_submit() (line 763 of /data/disk/b3share/static/ncjw-002/modules/file/file.field.inc).

It appears there are 2 issues that seem to be relevant: This one and this issue. So I'm not sure whether to apply the patch in comment 38 from this thread, or from comment 27 in the other thread.

@jimmb, try the dev release of Field collection, it now contains the patch I mentioned in #97 and may fix your issue.

Thanks Cottser. I upgraded to the dev version, and that did fix the problem for me.

Version:7.x-1.0-beta3» 7.x-1.0-beta4

- duplicate comment removed by author -

very good the #38
thanks for the patch worked excellent
code helped me a lot

Patch #38 solved the problem with field_collection 7.x-1.0-beta4,
thanks jec006 !!!

Status:Needs work» Needs review

#38: issue_1329856_1.patch queued for re-testing.

subscribe

no need to type subscribe anymore josegaert: http://drupal.org/node/1306444

#38 fixed the issue yeah!

Reporting that #38 fixed it for me too!

Status:Needs review» Reviewed & tested by the community

Can we possibly get the patch in #38 committed and close of this issue.

Status:Reviewed & tested by the community» Needs work

The patch in #38 still needs work as per fago in #95 and #96.

Status:Needs work» Needs review

#38: issue_1329856_1.patch queued for re-testing.

Status:Needs review» Needs work

Version:7.x-1.0-beta4» 7.x-1.x-dev
Priority:Normal» Critical

This seems like a blocker for getting a 1.0 module release out, which is part of the D7 Upgrade Initiative. Can we get an updated issue summary and steps to reproduce the bug?

I think the current state is that the patch from #38 needs a better test than $form_state['clicked_button']['#name'] == 'op'. What are we testing for exactly?

Priority:Critical» Normal
Issue tags:+D7 stable release blocker

This is an edge case bug, not a critical one. But it can be a release blocker.

Patch from #38 eliminated the error but now getting the following when going back in the 'field collections' interface :

Notice: Undefined index: invoice in _field_ui_bundle_admin_path() (line 325 of /Applications/MAMP/htdocs/Linode/MRFGR/modules/field_ui/field_ui.module).
Notice: Undefined index: invoice in field_collections_overview() (line 26 of /Applications/MAMP/htdocs/Linode/MRFGR/sites/all/modules/field_collection/field_collection.admin.inc).

#38 fixed for me also.

FYI / echoing #69 just for documentation:

It looks like #1468686-34: file_field_widget_submit(), file.field.inc using the wrong parent key fixes this in core. (Quicksketch confirms a core gotcha in #31.) Not sure whether that fixes all the problems reported here, but it may be an indication that this patch is not needed.

(Status: waiting to be included in D8 before being included in D7. #1468686-34 is the D7 fix.)

So the patch in #38 above issue can serve as a 'stop gap' until #1468686 is applied to core, if you like patching field_collection instead of drupal core... but it does not look like this needs more work.

Thank you, this core fix seems to have fixed the issue discussed in this thread - the mentioned warning messages don't appear after it's applied.