Update error (7007) if module is disabled while upgrading

exact same issue here

What version of Workbench Moderation did you upgrade from?

Same here, Updated from version 7.x-1.0.

Does this error occur repeatedly? Try clearing caches and running the update again. On client projects I've occasionally needed to build cache clears into update functions involving permissions. That might be needed in 7007 too.

Also, please change the status back to active when responding.

It does occur repeatedly. I just tried clearing the cache then running the update again, same error.

subscribing

I was able to reproduce this. Working on a fix.

My reproduction of the error turned out to be a bug in the install profile I was using.

Can you give me a list of the states and transitions configured on your site?

@jaza_sa You don't need to do that anymore, just click the "Follow" button, to subscribe to the thread.

This hasn't been updated in four weeks. Please reopen if there are specific instructions to reproduce.

I am also seeing this. I don't have further time to test right now but Workbench Moderation is currently disabled and I think this may be the cause.

Quickly tracing through the code suggests that calling user_role_change_permissions() from hook_update_N() will only work if the module that owns the permission is enabled during the update, as it eventually calls module_invoke_all('permission') to look for the module that owns the permission, but if the module is disabled this will be NULL.

Like many functions that eventually call module_invoke_all() I guess this means it is unsafe to call user_role_change_permissions() from hook_update_N() and you should modify the database directly in this case.

OK, so in fact I did have time to test quickly. I successfully updated via drush with:

drush en workbench_moderation
drush updb
drush dis workbench_moderation

I'll take the liberty to downgrade this to normal as it won't affect most users of this module.

I believe I have an idea why this happens. The workbench_moderation.module file is not loaded in .install file if the module is disabled. Therefore the workbench moderation permission from hook_permission cannot be found in user_role_change_permissions(). We only need to require_once the workbench_moderation.module file on top of the upgrade function and the issue should be solved. It is well known that this is required in .install files if modules are disabled.

Patch attached.