Now we've had the Facet API integration for some time, I guess we should drop the old, custom Facets module completely before we do a stable release.

Comments

davidseth’s picture

davidseth CreditAttribution: davidseth commented

Rather then get rid of it before the RC I would wait. This gives people a chance to upgrade without throwing everything out. Then you could say that the 2nd RC would completely get rid of this old Facet code.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey commented

That's not what an RC is for. Release candidate means it's what I propose as a stable release. Having still things that will surely be committed before the stable release at this point doesn't make any sense.
Also, if everything's OK, there won't even be an RC 2.

On the other hand, we really didn't have a Beta release since this changed (which is stupid anyways), so it would be hard for people not using the dev.
Therefore, it might be better to remove it in 1.1 …

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey commented
Issue tags: -D7 stable release blocker

OK, we'll do this in 1.1 and note it in the 1.0 release notes.
(Unless there are very good arguments against that.)

davidseth’s picture

davidseth CreditAttribution: davidseth commented

I think that is a sensible approach :)

Thanks.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey commented
Status: Active » Fixed

Fixed in 1.1.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented

Would it be possible to please clear up the project's information regarding what is necessary for facets to work? Right now this issue suggests that Facets API is necessary, the project page says that facets will only work with the Solr storage engine (without saying any other modules are necessary), and the Search API DB issue queue suggests it already supports facets.