hook_install_tasks() has $install_state parameter as well as install_tasks().

Files: 
CommentFileSizeAuthor
#7 documentation_fix_for_hook_install_tasks-1333400-7.patch991 bytesAlbert Volkman
PASSED: [[SimpleTest]]: [MySQL] 49,657 pass(es).
[ View ]
#4 documentation_fix_for_hook_install_tasks-1333400-4.patch985 bytesAlbert Volkman
PASSED: [[SimpleTest]]: [MySQL] 49,426 pass(es).
[ View ]
#1 documentation_fix_for_hook_install_tasks-1333400-0.patch1.1 KBChi
PASSED: [[SimpleTest]]: [MySQL] 33,815 pass(es).
[ View ]

Comments

Status:Active» Needs review
StatusFileSize
new1.1 KB
PASSED: [[SimpleTest]]: [MySQL] 33,815 pass(es).
[ View ]

Status:Needs review» Needs work

That is true, thanks for reporting this issue! This "hook" [it's not really a hook in the normal sense -- it's only for profiles] is called from
http://api.drupal.org/api/drupal/core--includes--install.core.inc/functi...
and it definitely passes in $install_state when it does:

   $function = $install_state['parameters']['profile'] . '_install_tasks';
    if (function_exists($function)) {
      $result = $function($install_state);

However, I'm not happy about the documentation line that is added. The hook that is being documented here just lists the tasks. Saying "This is passed along to each task, so it can be modified if necessary." doesn't make sense here, I think?

Status:Needs work» Needs review
StatusFileSize
new985 bytes
PASSED: [[SimpleTest]]: [MySQL] 49,426 pass(es).
[ View ]

I agree.

Status:Needs review» Reviewed & tested by the community

Looks good, thanks!

Status:Reviewed & tested by the community» Needs work

We need the datatype here, if I'm not mistaken.

Status:Needs work» Needs review
StatusFileSize
new991 bytes
PASSED: [[SimpleTest]]: [MySQL] 49,657 pass(es).
[ View ]

Datatype'd.

Status:Needs review» Reviewed & tested by the community

Status:Reviewed & tested by the community» Fixed

Thanks! Committed to 8.x and 7.x.

Automatically closed -- issue fixed for 2 weeks with no activity.