No empty 'default term value' when using 'Deny any new terms' on 'Edit field settings'page [#1334616]

I did the following, with autocomplete_deluxe from 14-oct-2011 on D7.9:
Add a field to a Content type:
- add a term refence field to a content type;
- this field is NOT required;
- used the Autocomplete Deluxe widget;
- automatically, the field 'Autocomplete settings' is set to 'Allow and insert new terms';

Create a new node:
- the term reference field is default empty; this is OK.

Go to the field settings:
- set the field 'Autocomplete settings' to 'Deny any new terms';
- the 'The default value for this field, used when creating new content.' is now set to a term. I have no means to make it empty.
- Save the field/content type anyway.

Create a new node:
- the term reference field is now filled with the default value; this is NOT OK.

IMO, the default term value can be empty in any of the combinations Required=yes/no + New terms=Deny/Allow

Comment	File	Size	Author
#10	autocomplete_deluxe_1334616_2.patch	6.62 KB	sepgil
#9	autocomplete_patch_1334616.patch	1.41 KB	sepgil
#3	1334616.patch	1.33 KB	sepgil
#2	autocomplete_deluxe-default_hack-1334616-2.patch	807 bytes	rooby

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

rooby CreditAttribution: rooby commented 14 December 2011 at 05:02

I can confirm this problem.

Comment #2

rooby CreditAttribution: rooby commented 14 December 2011 at 05:26

File	Size
autocomplete_deluxe-default_hack-1334616-2.patch	807 bytes

This is a quick hack of a fix that buys me some more time.
It isn't a proper fix but it does the job for me.

It doesn't stop the default widget on the field settings page from automatically selecting the first term but it gives an empty default value for the field when adding content, which is what I need.

Comment #3

sepgil CreditAttribution: sepgil commented 13 February 2012 at 12:58

Component:	Code	» Single list - deny new values
Assigned:	Unassigned	» sepgil

File	Size
1334616.patch	1.33 KB

I think an empty default value should only be allowed if field is not required. Else a default value must be selected. Therefore I think the patch should look similar like this:

Comment #4

johnv

Dutch

CreditAttribution: johnv commented 13 February 2012 at 19:54

@sepgil,
i don't agree. Even with required fields, it is possible to NOT supply a default. For the following reasons:
- Not supplying a default forces the user to make a choice. otherwise they'll be lazy and accept the default.
- Standard Drupal does it the same way.
ofcourse, admin can always set the default when required.

Comment #5

johnv

Dutch

CreditAttribution: johnv commented 13 February 2012 at 19:54

Status:

Active

» Needs review

Comment #6

sepgil CreditAttribution: sepgil commented 13 February 2012 at 23:08

@johnv: yeah that makes sense, but at least you should not be able to select nothing(like its currently possible with the lateset patch) if the field is required...

Comment #7

johnv

Dutch

CreditAttribution: johnv commented 14 February 2012 at 01:23

Correct, required is required...

Comment #8

rooby CreditAttribution: rooby commented 14 February 2012 at 03:25

I agree with #4 & #6.

Comment #9

sepgil CreditAttribution: sepgil commented 28 February 2012 at 14:03

File	Size
autocomplete_patch_1334616.patch	1.41 KB

I made a new patch, which only add an empty option if the field cardinality is 1 and if the field is not required. Please try it out.

Comment #10

sepgil CreditAttribution: sepgil commented 12 March 2012 at 13:50

File	Size
autocomplete_deluxe_1334616_2.patch	6.62 KB

The last patch... was not a good one...
This new patch solves this issue and the issue #1433876, since they are somehow connected.
Compared to my last patch, this one will not display the empty value for selection, since it somehow looked, like there was a bug.
Please test it out, and give me feedback!

Comment #11

johnv

Dutch

CreditAttribution: johnv commented 14 July 2012 at 15:42

@sepgil #10, you mean #1433876: Fix handling of new terms ?
Shouldn't that one be marked as a duplicate, then ?

I'd prefer to keep this issue small & simple: make sure the default_value should to be OK, with or without this module.

I didn't get this working, but I now understand the misunderstanding: you proudly use your own widget for the 'default value' on the field settings page. This is nice, but makes the widget more complicated.
On the settings page, the default value is not required, even if the field is required.
We need an unambiguous way do see in which of 2 screens we are.
Perhaps we should throw in a hook_form_field_ui_field_edit_form_alter(&$form, $form_state) , so we can make a difference between edit page and settings page?

        $options = autocomplete_deluxe_allowed_terms($field);
//        $options = array('' => '') + autocomplete_deluxe_allowed_terms($field);
//        $options = (empty($element['#required'])  && empty($multiple) ? array('' => '') : array()) + autocomplete_deluxe_allowed_terms($field);
//        $options = (isset($element['#required']) ? array('' => '&nbsp;') : array()) + autocomplete_deluxe_allowed_terms($field);