D7 imagecache external function

Thanks for your work! I hope to have time next week to work on this module. Can you supply a git patch? This is more difficult to work with.

Hi, Does this extention need: http://drupal.org/node/975222/release ? Imagecache_external itself?

Edit: I see that the img_style is hardcoded. I do not think that is correct:

function link_image_field_formatter_info() {
  return array(
    'link_image' => array(
      'label' => t('Image with URL as source, title as alt tags.'),
      'field types' => array('link_field'),
	  'settings'  => array( //Default settings
        'img_style' => 'thumbnail',  <======
      ),
    ),
  );
}

I am not able to change the image style from thumbnail to another. Thanks for your help in advance.
Edit2: I am able to change the image style. It is working ok. It was a panels setting on my behave.

Greetings, Martijn

Hi,
Yes it is working great now, thanks for building this!
The other thing you put on, I do not see, but will check it.
Greetings, Martijn

Hi,
I have somehow a problem with image urls like underneath . Image Url's with arguments
Somehow these url's are not correctly transfered to imagecache_external.

http://wintersport.sunweb.nl/utilpages/getimage.ashx?width=264&height=176&file=Images/Web1/100000/32000/132999-Web1.jpg

Somehow the variable after the first ? is forgotten.
The error report says for imagecache_external:

The image http://wintersport.sunweb.nl/utilpages/getimage.ashx could not be retrieved

I think this is maybe because of unmissing arguments through

$image = array(
    'path' =>  $item['url'],
	'style_name'=> $item['style_name'],
  );

I am not a programmer, so sorry if I am completely mistaken!
Greetings,
Martijn

Hi, anyone knows what is wrong here please?
Thanks a lot in advance for your reply!
Greetings, Martijn

Hi Summit,

I run across your problem, you are right the query part of the url is missing ie the part after the '?' . I changed the code to be like this:

function theme_link_image_formatter($vars) {
  $item = $vars['element'];

  // add the query part back to the url, provided there is any
  if(isset($item['query'])) {
    $query = "?";
    foreach ($item['query'] as $key => $value) {
      $query = $query . $key . "=" . $value . "&"; 
    }
    $fullurl = $item['url'] . $query;
    } else {
      $fullurl = $item['url'];
  }

  $image = array(
    'path' => $fullurl,
	'style_name'=> $item['style_name'],
  );

This works for me, with the example you provided. Hope it helps.

Hi,
Will this be committed please?
Greetings, Martijn

@Summit, if a patch is supplied I'll commit it.

Here is a summary patch that fix several issues and add a new feature.

Fixes

• D7 imagecache external function (this issue). Original code from @martysteer, see original post.
• Support for urls with a query part. Original code from @pefferen, see comment #1335594-7: D7 imagecache external function.
• #1399096: Error in deinstall script. Original code from @Summit.

New features

• New option for showing the link title as a caption, below the rendered image (this code is mine ;)
• Imagecache External module is not a dependency