Problem/Motivation

  • taxonomy_autocomplete() documentation lacks proper API documentation.
  • Multiple open issues need to update this docblock, and so far each issue includes its own variant.

See also: #1326644: Clean up API docs for taxonomy module

Proposed resolution

Stop the madness. :) Give this function a docblock sooner rather than later so that every bugfix doesn't write its own variant. Patch in #3 adds this docblock.

Remaining tasks

None.

User interface changes

None.

API changes

None.

Files: 
CommentFileSizeAuthor
#9 taxonomy_autocomplete-d7-1337124-9.patch1.54 KBxjm
PASSED: [[SimpleTest]]: [MySQL] 37,043 pass(es).
[ View ]
#6 taxonomy_autocomplete-1337124-6.patch1.56 KBxjm
PASSED: [[SimpleTest]]: [MySQL] 33,984 pass(es).
[ View ]
#3 taxonomy_autocomplete-1337124-3.patch1.56 KBxjm
PASSED: [[SimpleTest]]: [MySQL] 33,979 pass(es).
[ View ]
#2 taxonomy_autocomplete_docblock.patch1.56 KBxjm
PASSED: [[SimpleTest]]: [MySQL] 33,961 pass(es).
[ View ]
#1 taxonomy_autocomplete_docblock.patch1.56 KBxjm
PASSED: [[SimpleTest]]: [MySQL] 33,965 pass(es).
[ View ]

Comments

Status:Active» Needs review
StatusFileSize
new1.56 KB
PASSED: [[SimpleTest]]: [MySQL] 33,965 pass(es).
[ View ]

StatusFileSize
new1.56 KB
PASSED: [[SimpleTest]]: [MySQL] 33,961 pass(es).
[ View ]

And without the whitespace this time.

StatusFileSize
new1.56 KB
PASSED: [[SimpleTest]]: [MySQL] 33,979 pass(es).
[ View ]

ksenzee pointed out it's an object, not an array. Curse you, JavaScript!

Status:Needs review» Reviewed & tested by the community

Looks good to me.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Status:Reviewed & tested by the community» Needs review

+ * @code
+ *   {
+ *     "red fish, blue fish": "blue fish",
+ *     "red fish, blue moon": "blue moon",
+ *   };
+ * @endcode
+ *
+ *
+ * @param $field_name

Looks like one too many line breaks?

StatusFileSize
new1.56 KB
PASSED: [[SimpleTest]]: [MySQL] 33,984 pass(es).
[ View ]

That is entirely possible.

Status:Needs review» Reviewed & tested by the community

RTBC again

Version:8.x-dev» 7.x-dev
Status:Reviewed & tested by the community» Patch (to be ported)

Committed/pushed to 8.x, will need a re-roll for 7.x.

Status:Patch (to be ported)» Reviewed & tested by the community
StatusFileSize
new1.54 KB
PASSED: [[SimpleTest]]: [MySQL] 37,043 pass(es).
[ View ]

Same docblock, different branch.

Assigned:xjm» Unassigned

Status:Reviewed & tested by the community» Fixed

Committed to 7.x.

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue summary:View changes

Making it a bit more legible. ;)