Allow debugging to be disabled [#1337140]

This patch allows Galleria's debug option to be disabled via the Galleria option-sets configuration user interface. It is a lot like #1301894: Add support for theme-specific options but the debug option applies regardless of which theme is used.

debug can not be set via the existing "custom" options because Galleria checks it's value strictly:

if ( options && options.debug === false ) {

And neither an empty string ('') or the zero character ('0') evaluate === false to true.

Comment	File	Size	Author
	debug.patch	760 bytes	Bevan

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

kroimon CreditAttribution: kroimon commented 10 November 2011 at 01:44

debug can not be set via the existing "custom" options because Galleria checks it's value strictly

Well, you could have typed in true or false which automagically gets converted into a boolean value ;-)

But thanks for the patch, I just committed it, so it is in the next -dev version, which should be available in a few hours!

Comment #2

kroimon CreditAttribution: kroimon commented 10 November 2011 at 01:46

Status:

Needs review

» Fixed

Comment #3

Bevan CreditAttribution: Bevan commented 14 November 2011 at 03:08

Doh! That feature really needs better documentation in the UI! :)

Comment #4

kroimon CreditAttribution: kroimon commented 14 November 2011 at 17:23

Status:

Fixed

» Needs work

Yeah, you're probably right.
Re-opening this so I remember to add a short description text next to the custom option input field and maybe some lines in the readme file.

Edit: You're welcome to provide a patch for that ;-)