The help for core-quick-drupal gives an example
drush qd --profile=minimal --dev --cache --default-major=8 --yes
which fails
Unknown option: --default-major. See `drush help core-quick-drupal` for information on usage. [error]

CommentFileSizeAuthor
#3 drush-qd_core_example-134539-3.patch1.52 KBeporama
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bfroehle’s picture

bfroehle CreditAttribution: bfroehle commented

I suspect the example should instead use --core=drupal-8.x.

greg.1.anderson’s picture

greg.1.anderson CreditAttribution: greg.1.anderson commented

If the command declared pm-download in 'drush dependencies', then it should recognize all of the dl options, including --default-major. See `drush topic docs-commands`.

eporama’s picture

eporama CreditAttribution: eporama commented
FileSize
drush-qd_core_example-134539-3.patch1.52 KB

Although the function drush_core_quick_drupal_options() in core.drush.inc specifically unsets this.

unset($options['default-major']);

So adding $items['core-quick-drupal']['drush dependencies'] = array('pm'); doesn't work in this case.

I've attached a patch to at least get the example to match the current options so that while this is figured out, we at least are consistent.

eporama’s picture

eporama CreditAttribution: eporama commented
Status: Active » Needs review

realized I never set my previous patch to needs review

moshe weitzman’s picture

moshe weitzman CreditAttribution: moshe weitzman commented
Status: Needs review » Fixed

Committed. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.