API page: http://api.drupal.org/api/drupal/modules--node--node.module/function/nod...

Describe the problem you have found:
Return value
Current:
A fully-populated node object.
Expanded:
A fully-populated node object or false if the node is not found.

CommentFileSizeAuthor
#9 1345480-d7-node_load_return_documentation.patch555 byteschris.leversuch
#8 1345480-node_load_return_documentation-D7.patch555 byteschris.leversuch
#5 1345480-node_load_return_documentation.patch588 byteschris.leversuch
#3 node_load_return_documentation-1345480.patch587 bytesrbayliss
#3 node_load_return_documentation-1345480-D7.patch554 bytesrbayliss
#3 node_load_return_documentation-1345480-D6.patch528 bytesrbayliss
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Version: 7.x-dev » 8.x-dev
Issue tags: +Needs backport to D6, +Novice, +Needs backport to D7

That sounds like a good change to make, in D8/7 documentation, and actually D6 too. Looks like a good project for a novice contributor...

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Title: Documentation problem with node_load » node_load does not document FALSE return value
rbayliss’s picture

rbayliss CreditAttribution: rbayliss commented
Status: Active » Needs review
FileSize
node_load_return_documentation-1345480-D6.patch528 bytes
node_load_return_documentation-1345480-D7.patch554 bytes
node_load_return_documentation-1345480.patch587 bytes

Patches attached.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Needs work

Thanks! Can you add a comma before the "or"?

Also, I recommend just making the patch for D8 on the first go-around, and then after that patch has been accepted and committed, only then making a d7 or d6 version. This saves time and effort, since there are often changes reviewers point out that are needed in the d8 version -- might as well get that right before taking the time to port it to other versions of Drupal.

chris.leversuch’s picture

chris.leversuch CreditAttribution: chris.leversuch commented
Status: Needs work » Needs review
FileSize
1345480-node_load_return_documentation.patch588 bytes

D8 patch with , included

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Reviewed & tested by the community

Looks good, thanks!

Dries’s picture

Dries CreditAttribution: Dries commented
Version: 8.x-dev » 7.x-dev

Committed to 8.x. Moving to 7.x.

chris.leversuch’s picture

chris.leversuch CreditAttribution: chris.leversuch commented
Status: Reviewed & tested by the community » Needs review
FileSize
1345480-node_load_return_documentation-D7.patch555 bytes

D7 version.

chris.leversuch’s picture

chris.leversuch CreditAttribution: chris.leversuch commented
FileSize
1345480-d7-node_load_return_documentation.patch555 bytes

Different file name fo testing

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Reviewed & tested by the community

Thanks, ready for D7 too. :)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 7.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.