Convert theme_breadcrumb() to HTML5

Task: Tests need to be modified to match the new html structure of the breadcrumb.

This is going to fail again for node title, attaching a new patch

Another try :)

+++ b/core/includes/theme.incundefined
@@ -1679,13 +1679,16 @@ function theme_image($variables) {
+    $output = '<nav role="nav" class="breadcrumb">';

You mean role="navigation" :)

Fixed the "navigation" thing

I had a question about using nav for breadcrumbs, as they aren't 'major', but the W3C seems to support it here: dev.w3.org/html5/spec/Overview, section 4.13.2.

really?

Looking at #16 comment, let's mark this as needs work then and unassign it.

Here's some CSS cleanup.

Also the ' » ' shouldn't be added to the last breadcrumb.

And theme_breadcrumb() should still return a string even if its empty; conditionally returning VOID is bad form.

Lastly, we shouldn't have any <?php if ($breadcrumb): ?> in any page.tpl.php files.

In IRC, people were asking (rightly) about whether » was good for RTL languages. It is. See http://drupal.org/node/179781#comment-610051

Tagging for the next sprint.

The list containing the breadcrumbs should really be an <ol> instead of an <ul>.
The order of the breadcrumbs matters.

I thought the only difference between ol and ul was that ol contains number and ul conains shapes. And we hide those anyway.
So I don't know why <ol> should be better than <ul> ?

@aspilicious it's not about the bullet style, and technically @maartenverbaarschot is correct, IMO. Here's a little about the difference:

OL spec definition:

The ol element represents a list of items, where the items have been intentionally ordered, such that changing the order would change the meaning of the document.

UL spec definition:

The ul element represents a list of items, where the order of the items is not important — that is, where changing the order would not materially change the meaning of the document.

So... gonna mark needs work unless anyone else has something to say about it. :)

That's a really interesting semantic difference, and I kinda like it :)

Changed the ul to ol in the theme function, the CSS, and the tests.

Thank you @tim.plunkett! Looks good to me. :)

Looks good to me, and I think the <ol> is a nice touch here. Committed/pushed to 8.x.

$this->assertEqual(current($this->xpath($xpath)), $node->title, 'Node breadcrumb is equal to node title.', 'Node');

should maybe be changed to use t() for the title text.

I don't think it's advised to use t() in tests

We don't need t() function in assertions, discussed here: #500866: [META] remove t() from assert message