Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
There is a conflict now with using the class addthis_button_[service]. You can't add this bubble style now. Because service names are added dynamicly to addthis_button you would have a problem when you want to add the bubble style as a decorated link in the toolbox.
Proposed resolution
Add extra validation for specific alternate service names.
Remaining tasks
Review.
User interface changes
API changes
Original report by @matglas86
There is a conflict now with using the class addthis_button_[service]. You can't add this bubble style now. Because service names are added dynamicly to addthis_button you would have a problem when you want to add the bubble style as a decorated link in the toolbox.
Comment | File | Size | Author |
---|---|---|---|
#5 | 1348502-4.patch | 2.7 KB | matglas86 |
Comments
Comment #1
mortona2k CreditAttribution: mortona2k commentedAny progress?
Comment #2
tjerkdekuijper CreditAttribution: tjerkdekuijper commentedTry the following, works for me. Had no time to build a patch.
in addthis.displays.addthis.inc line number 37 change this:
into this:
Comment #3
tjerkdekuijper CreditAttribution: tjerkdekuijper commentedEven better, as of version 7.x-4.x you can use use HOOK__addthis_markup_alter to this. See example below:
Comment #5
matglas86 CreditAttribution: matglas86 commentedI already merged this into development but can change it if neccesary.
Please test the styles added. bubble_style and pill_style.
Commit 93a48
Comment #6
matglas86 CreditAttribution: matglas86 commentedI'm going to put it fixed. If problems come up. Let me know.