Allow other modules to modify the menu structure [#1349202]

The menu structure generated by the module at /sitemap cannot be modified at all. This makes it impossible for other modules to jump in.

For example, Special Menu Items adds two new tokens on top of ( and ). Adding a hook would enable this module or a glue module to avoid these entries to generate a non existent link.

Comment	File	Size	Author
#3	1349202_add_hook_sitemap_menu_tree_alter_3.patch	538 bytes	juampynr
#3
#2	1349202_add_hook_sitemap_menu_tree_alter_2.patch	638 bytes	juampynr
#2
#1	1349202_add_hook_sitemap_menu_tree_alter.patch	638 bytes	juampynr
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

juampynr CreditAttribution: juampynr commented 22 November 2011 at 10:08

File	Size
1349202_add_hook_sitemap_menu_tree_alter.patch	638 bytes

Attaching patch to be reviewed.

Here is an example of how Special Menu Items could make links to <nolink> to point to the sitemap page:

  /**
   * Implements hook_site_map_menu_tree_alter
   *
   * Removes wrong URLs for special_menu_item paths
   */
  function mymodule_site_map_menu_tree_alter($menu_display) {
    foreach ($menu_display as $id => $item) {
      if (isset($item['#href']) &&
        ($item['#href'] == '<nolink>' || $item['#href'] == '<separator>')) {
          $menu_display[$id]['#href'] = 'sitemap/#';
      }
    }
    return $menu_display;
  }

Comment #2

juampynr CreditAttribution: juampynr commented 22 November 2011 at 10:10

File	Size
1349202_add_hook_sitemap_menu_tree_alter_2.patch	638 bytes

Attaching an improved patch with right paths in the diff.

Comment #3

juampynr CreditAttribution: juampynr commented 22 November 2011 at 10:12

File	Size
1349202_add_hook_sitemap_menu_tree_alter_3.patch	538 bytes

Sorry, uploaded the same one. Here it is.

Comment #4

darrell_ulm CreditAttribution: darrell_ulm commented 5 May 2012 at 01:32

Priority:

Major

» Normal

Looks interesting.

Hey offhand, can anyone tell me if there are possible security implications for this?

Just checking.

Comment #5

juampynr CreditAttribution: juampynr commented 5 May 2012 at 09:53

Issue tags:

+Needs security review

Here is the related issue on Special Menu Items: #1104940: filter out Special menu items from xml sitemap.

The risk of adding a hook would depend entirely on what the module that hooks in does, but it does not add any security breach by itself. However, I have added the tag Needs Sec Review to this issue.