Hi,
While going through my error-log, I realized that our comment RSS feed consistently gave out notices. So I set out to investigate why, and the reason is really simple..
In modules/comment/views_plugin_row_comment_rss.inc, line 39 it tries to read $this->options['item_length'], no such option exists - neither views_plugin_row_comment_rss, nor it's two parent classes views_plugin_row and views_plugin has the option 'item_length' listed in their option-definitions.
Is the item_length option a left-over of a local option that was removed, or did some of the parent classes change? In either way, it's a, in my eyes, a bug.
Regards
Morten
Comment | File | Size | Author |
---|---|---|---|
#6 | 1355520.patch | 2.44 KB | dawehner |
#2 | 1355520.patch | 1.56 KB | dawehner |
Comments
Comment #1
fangel CreditAttribution: fangel commentedAlso, the same is true for the option 'links' used further down in line 81.
AND a third bug is using the wrong index into the $this->nodes-array in line 73
it should be
because it doesn't make sense to use the cid as the index into the nodes array.
Comment #2
dawehnerThis problems got introduced by #1243220: Cleanup RSS content building and handling
So what about this patch?
Comment #3
fangel CreditAttribution: fangel commentedThat's a good start, although the method
options_form_summary_options()
isn't defined in eitherviews_plugin_row_comment_rss
orviews_plugin_row
.So either the parent-class needs to be updated, or that method needs to be added to the class..
Comment #4
dawehnerWhat's the problem with the not implemented options_form_summary_options ? This sounds a bit more like a feature request though.
Comment #5
fangel CreditAttribution: fangel commentedThe problem is that you use it as the #options-directive in the options-form.. Hence not implementing it is sort of a problem, as you would get fatal errors otherwise ;)
+ '#options' => $this->options_form_summary_options(),
Comment #6
dawehnerUps! Thanks for spotting the problem!
Never trust me if i write something like "what about this patch" :)
Here is a patch which should solve the problem.
Comment #7
dawehnerSome manual testing later i committed a working version of the patch.
Thanks for helping on this issue.