Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Comment | File | Size | Author |
---|---|---|---|
#9 | taxonomy_display-display_per_term-1355960-9.patch | 19.04 KB | evanbarter |
#8 | taxonomy_display-display_per_term-1355960-8.patch | 17.54 KB | evanbarter |
#7 | taxonomy_display-display_per_term-1355960-7.patch | 17.24 KB | codycraven |
#5 | per_term-1355960-5.patch | 15.17 KB | evanbarter |
Comments
Comment #1
codycraven CreditAttribution: codycraven commentedI see this as a good feature request. However it I believe it would conflict with the another feature request ( #1170146: Setting where the associated content appears ) that I am already planning on adding. As such I'd need to figure out a way to make the two play nicely before I would consider adding it to the module.
Comment #2
skolesnyk CreditAttribution: skolesnyk commentedThanks for replying, codycraven.
In the meantime do you know if is there any immediate solution?
Comment #3
codycraven CreditAttribution: codycraven commentedskolesnyk as an immediate solution you could make use of panels. That would allow you to set the default taxonomy display and create variants for any specially displayed terms you desire.
Comment #4
codycraven CreditAttribution: codycraven commentedMarking postponed until a final decision is made. Right now I am leaning towards this specific need being handled by panels rather than add a lot of complexity to the module for a limited use case.
Comment #5
evanbarter CreditAttribution: evanbarter commentedI know the module maintainer said he has bigger plans for this functionality but this is something I needed for a site my employer is working on right now and it looks like development has ceased on this module. Attached patch allows you to add a custom taxonomy display to an individual term which can be configured like a vocabulary. Reviews welcome.
Comment #6
codycraven CreditAttribution: codycraven commentedevanbarter,
Thanks for the patch. Development has not ceased on the project, I've just been limited on time and have mainly been acting on bug reports (when they come rather than new functionality).
I'm going to thoroughly review your patch and if it looks like everything is heading in the right direction (from a brief skimming it does) I'm going to make some tweaks and post it back here for further review before committing as new functionality.
Comment #7
codycraven CreditAttribution: codycraven commentedAttached is an updated patch.
Modified fetch. Drupal now performs a single query when attempting to load a term's display configuration. This query prioritizes individual configuration and if not found will use the vocabulary's configuration.
Modified delete. When deleting a vocabulary all taxonomy displays for that vocabulary will now be removed, including those for individual terms.
Note that I have not tested this patch at all yet. It's just based on reviewing the patch in #5.
Comment #8
evanbarter CreditAttribution: evanbarter commentedHey codycraven, great to hear development is ongoing and thanks for reviewing the patch so quickly. I've taken a look at your patch and like the changes you made to it. Patch attached simply removes some extra whitespace.
Comment #9
evanbarter CreditAttribution: evanbarter commentedPatches #7 & #8 introduced a bug where by in attempting to save a new term taxonomy display, taxonomy_display_fetch_taxonomy_display() would return a vocabulary taxonomy display as a fallback. Because 'no_record' wasn't set in this case, the module attempted to do an update that silently failed. Attached patch is a bit more stringent, it checks 'no_record' and ensures that the machine name and tid match up as well.
Comment #10
codycraven CreditAttribution: codycraven commentedI just thought of something. On the term edit pages we need to add a checkbox that will enable/disable term overriding from the vocabulary.
Otherwise the vocabulary configuration will be useless over time as every term that's saved will save it's own configuration. The checkbox should, upon term save be verified if it was checked or not. If checked the term configuration should be saved, if unchecked the previous term configuration (if any) should be deleted.
Comment #11
codycraven CreditAttribution: codycraven commentedComment #12
hixster CreditAttribution: hixster commentedany movement on this guys, we've been using TVI to similar things, but Taxonomy Display appears to have more options.
Maybe we can contribute in some way? Just checking status first
Comment #13
codycraven CreditAttribution: codycraven commentedhixster,
You can definitely contribute. There has been no movement on the issue as it is not a feature that I personally need and I don't think the majority of module users would either.
However, if a patch is made which adds the functionality in a non-destructive way I'm happy to add it.
Comment #14
ajlow CreditAttribution: ajlow commented*bump*
Is there a patch for the latest dev version?
The above patches failed for the dev as well as the recommended released 7.x-1.1 2012-Oct-30...
Comment #15
Andrew Gorokhovets CreditAttribution: Andrew Gorokhovets commentedSubscribe
Comment #16
Nikolay ShapovalovSo much time left, but still feature request. Very sadly.
Comment #17
hockey2112 CreditAttribution: hockey2112 commentedAlso interested in this. Any word on when or if it might be added to the latest dev?