Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
When using ajax you can't see events for previous months although the days are showing. See this issue: #1279588: Load additional events when using ajax So it would be nice if there was an option to hide the days for the previous/next month from displaying so it doesn't confuse anyone.
Comment | File | Size | Author |
---|---|---|---|
#13 | fullcalendar-1356284-13.patch | 1.18 KB | tim.plunkett |
#11 | fullcalendar-1356284-11.patch | 0 bytes | tim.plunkett |
#10 | 1356284-d7-7.patch | 2.4 KB | redndahead |
#9 | 1356284-d7-6.patch | 2.34 KB | redndahead |
#8 | 1356284-d7-5.patch | 2.29 KB | redndahead |
Comments
Comment #1
redndahead CreditAttribution: redndahead commentedHere is the patch
Comment #2
redndahead CreditAttribution: redndahead commentedCouple of comments on this patch
1) Variable/class names can easily change. I wasn't sure what to call them.
2) I had to wrap the form element in a div and clear:both; to make it look right. This doesn't seem like the best option is there something else I can do to move it to the next line?
Comment #3
tim.plunkettshould be
Is this really necessary?
Use
!empty()
.In general, we're using camelCase for options defined by the plugin itself, our custom options should be not_camel_case.
Comment #4
redndahead CreditAttribution: redndahead commentedHere are the fixes.
Comment #5
redndahead CreditAttribution: redndahead commentedWhite space removal
Comment #6
tim.plunkettThis should be in fullcalendar_fullcalendar_options_process() which is in includes/fullcalendar.fullcalendar.inc
Comment #7
redndahead CreditAttribution: redndahead commentedHere you go.
Comment #8
redndahead CreditAttribution: redndahead commentedGood call on making sure I tested ;) There was a bug, I should have been using empty() instead of !empty()
Comment #9
redndahead CreditAttribution: redndahead commentedAfter some more irc discussions. Using display: none caused some height issues. So we now make the text go far far away.
Comment #10
redndahead CreditAttribution: redndahead commentedNow in the fullcalendar_options module. I still need to test. But a code review will help.
Comment #11
tim.plunkettHaving it be "uncheck" to disable doesn't work unless we write more upgrade path code, since it will register as unchecked until the view is resaved.
So this switches it to "Check to disable".
Note, if you've installed FullCalendar Options before, you have to go to admin/config/user-interface/fullcalendar/options and check that checkbox. Writing a hook_update_N for this is probably a waste of time.
The real problem here, is that while a negative text-indent hides the number, but does not hide the events. Display:none messes things up in other ways.
Reading through http://code.google.com/p/fullcalendar/issues/detail?id=166, it seems like this can only be truly fixed in the plugin.
Comment #12
tim.plunkettI think instead of exposing this, we should just add it as the default behavior for ajax-based views until #1279588: Load additional events when using ajax is fixed. Thoughts?
Comment #13
tim.plunkettComment #14
redndahead CreditAttribution: redndahead commentedTested this with ajax on and off. It works as advertised. Thanks Tim
Comment #15
redndahead CreditAttribution: redndahead commented#1279588: Load additional events when using ajax will take care of the need for this patch. Marking as won't fix.