Edit link not displayed on own comments, 6.x-1.7 [#1356390]

This appears to be a recurrence of issue #597616: Edit link not displayed on own comments.

That issue was fixed with this commit: http://drupalcode.org/project/forum_access.git/commitdiff/227204a

...but later on refactoring dropped that fix.

I've attached a patch, which applies to 6.x-1.7.

Comment	File	Size	Author
#4	forum_access_comment_access.1356390.5.TestOnly.patch	3.84 KB	salvis
#4
#4	forum_access_comment_access.1356390.5.TestAndFix.patch	4.41 KB	salvis
#4
#3	forum_access-comment-edit-02.patch	580 bytes	smokris
#3
	forum_access-comment-edit.patch	541 bytes	smokris

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

29 November 2011 at 23:24

Status:

Needs review

» Needs work

The last submitted patch, forum_access-comment-edit.patch, failed testing.

Comment #2

salvis

he/his

CreditAttribution: salvis commented 30 November 2011 at 07:39

Version:

6.x-1.7

» 6.x-1.x-dev

The testbot says "fatal: unable to find filename in patch at line 1".

--- forum_access.module.orig	2011-11-29 17:48:55.000000000 -0500
+++ forum_access.module	2011-11-29 18:03:33.000000000 -0500

The testbot requires patches to be in -p1 format, like this:

--- a/forum_access.module	2011-11-29 17:48:55.000000000 -0500
+++ b/forum_access.module	2011-11-29 18:03:33.000000000 -0500

Also, patches need to be tested against the tip of the branch.

File	Size
forum_access-comment-edit-02.patch	580 bytes

Comment #4

salvis

he/his

CreditAttribution: salvis commented 1 December 2011 at 02:13

File	Size
forum_access_comment_access.1356390.5.TestAndFix.patch	4.41 KB

forum_access_comment_access.1356390.5.TestOnly.patch	3.84 KB

It's nice that it passed, but actually, it should not have passed...

The fact that it passed means that either it didn't make any difference, or that our tests fail to test this aspect. I've added the missing tests. The first patch (without your #3) must fail, and the second (with your #3 should then pass...