[META] Clean up icons in misc

The second is covered by #1246722: Replace or rename redundant watchdog icons already.

For the third, there's #905988: Provide "Powered by Drupal"-Icons with transparent background

Closely related: #436500: Modernize generic menu icons/arrows in /misc

I think it would make more sense to focus this issue back on the forum icons only...?

Can any of these get replaced by #1744278: Make use of jQuery UI Icons in core?

Do we have any SVG files for the existing images?

Patch moves forum icon and updates forum css

other issues:
- powered by drupal: Already have been removed from misc folder
- Consolidate warning and message-16.png: Not sure which to go yet. Probably the smaller message-16.png file

add more stuff that needs cleanup in misc

I think we could remove some of these icons now that we have #2032773: Use Libricons (icon font) in Seven, consider using it more broadly in core

List of icons that are no longer referenced in core:

• configure.png
• configure-dark.png only in tests
• draggable.png
• edit.png
• edit-active.png
• grippie.png only in tests
• help.png
• loading.gif
• menu-collapsed-rtl.png
• menu-collapsed.png
• menu-expanded.png
• menu-leaf.png
• message-16-error.png
• message-16-help.png
• message-16-info.png
• message-16-warning.png
• message-24-error.png
• message-24-help.png
• message-24-info.png
• message-24-ok.png
• message-24-warning.png
• permissions.png

... that's I bigger list than I was expecting! I doubled checked a few of these.

I've combined the patch in #4 with deletion of the 22 files in #7.
The patch should work: the txt file should be easier to read (made using gif diff -D).

The bot likes it. What testing needs to happen to mark this RTBC?

Is someone else able to sanity check this for me?

Ok, I only have found a couple of missing icons in node/add/article. I have opened a follow-up for that in #2208263: Missing icons in admin pages.

The rest is working for me. Maybe RTBC?

Going to re-add missing icons after discussing it with @lewisnyman.

Re-rolled patch and re-added menu-collapsed.png, menu-collapsed-rtl.png and help.png icons.

I applied #14 and clicked through many many pages to check if there are any 404 errors for images. I also enabled 5 modules that are not enabled by default to double check them incase anything was missed. I could not find any missing image errors so the patch is good.

Could we please get an updated issue summary that explains what this patch is doing (and why)? I can't quite parse it out.

Ok on it. How's that?

This doesn't appear to modify the test that references grippie.png?

  /**
   * Tests \Drupal\Core\Image\Image::setSource().
   */
  public function testSetSource() {
    $source = __DIR__ . '/../../../../../misc/grippie.png';
    $this->image->setSource($source);
    $this->assertEquals($this->image->getSource(), $source);
  }

Here you go @catch

- Drupal hero

Nice one! The patch still looks good.

Ok great, thanks!

Committed and pushed to 8.x.

configure-dark.png seems to be used on the "Manage Display" page of a content type.
I am on latest git version (where the icons have been removed) and go this 404 image:

:(

This follow-up patch restores core/misc/configure-dark.png from commit fba6f74.

Ah it wasn't in the CSS, that's maybe why it was missed. Here's a screenshot of it looking better.

I think menu-expanded.png deleted in fab42693f81b93b4228162021ce916ef5feb13c7 should be restored since is giving me 404s and is referenced in:

core/themes/seven/style.css:  list-style-image: url(../../misc/menu-expanded.png);
core/modules/simpletest/lib/Drupal/simpletest/Form/SimpletestTestForm.php:      '#uri' => 'core/misc/menu-expanded.png',
core/modules/locale/css/locale.admin.css:  background: transparent url(../../../misc/menu-expanded.png) left .6em no-repeat;
core/modules/system/css/system.theme.css:  background: url(../../../misc/menu-expanded.png) 0px 100% no-repeat; /* LTR */
core/modules/system/css/system.theme.css:  list-style-image: url(../../../misc/menu-expanded.png);

I've confirmed the second followup patch. Both patches are RTBC.

Let's revert this patch entirely, please.

It clearly looks like image filenames were grepped in .css files only.

@sun That can't be it, because menu-expanded appears in css.

Are there any other files that we accidentally removed? If there aren't then it's a waste reverting it now... I'll take a look.

Hm. For now, I've rolled this back, because it looks like there's at least two spots that were missed (#26 and #28). We'll need one single patch with all of the proper files moved here and there as well.

Also tagging "needs manual testing" because yeah. ;)

Grepping the codebase for references to the files in #7

• configure.png
  

  grep -r configure.png . | grep -v ./.git/index | wc -l
         0

• configure-dark.png
  

  grep -r configure-dark.png . | grep -v ./.git/index | wc -l
         1

• draggable.png
  

  grep -r draggable.png . | grep -v ./.git/index | wc -l
         0

• edit.png
  

  grep -r edit.png . | grep -v ./.git/index | wc -l
         0

• edit-active.png
  

  grep -r edit-active.png . | grep -v ./.git/index | wc -l
         0

• grippie.png
  

  grep -r grippie.png . | grep -v ./.git/index | wc -l
         2

• help.png
  

  grep -r help.png . | grep -v ./.git/index | wc -l
         2

• loading.gif
  

  grep -r loading.gif . | grep -v ./.git/index | wc -l
         0

• menu-collapsed-rtl.png
  

  grep -r menu-collapsed-rtl.png . | grep -v ./.git/index | wc -l
         1

• menu-collapsed.png
  

  grep -r menu-collapsed.png . | grep -v ./.git/index | wc -l
         4

• menu-expanded.png
  

  grep -r menu-expanded.png . | grep -v ./.git/index | wc -l
         5

• menu-leaf.png
  

  grep -r menu-leaf.png . | grep -v ./.git/index | wc -l
         0

• message-16-error.png
  

  grep -r message-16-error.png . | grep -v ./.git/index | wc -l
         3

• message-16-help.png
  

  grep -r message-16-help.png . | grep -v ./.git/index | wc -l
         0

• message-16-info.png
  

   grep -r message-16-info.png . | grep -v ./.git/index | wc -l
         0

• message-16-warning.png
  

  grep -r message-16-warning.png . | grep -v ./.git/index | wc -l
         0

• message-24-error.png
  

  grep -r message-24-error.png . | grep -v ./.git/index | wc -l
         0

• message-24-help.png
  

  grep -r message-24-help.png . | grep -v ./.git/index | wc -l
         0

• message-24-info.png
  

  grep -r message-24-info.png . | grep -v ./.git/index | wc -l
         0

• message-24-ok.png
  

  grep -r message-24-ok.png . | grep -v ./.git/index | wc -l
         0

• message-24-warning.png
  

  grep -r message-24-warning.png . | grep -v ./.git/index | wc -l
         0

• permissions.png
  

  grep -r permissions.png . | grep -v ./.git/index | wc -l
         0

Amended list of files not referenced

• configure.png
• draggable.png
• edit.png
• edit-active.png
• loading.gif
• menu-leaf.png
• message-16-help.png
• message-16-info.png
• message-16-warning.png
• message-24-error.png
• message-24-help.png
• message-24-info.png
• message-24-ok.png
• message-24-warning.png
• permissions.png

Steps to create a new patch

Amending the 1356602-clean-up-misc-15.patch from #19, which adds/deleted/amends the following files:

• core/misc/configure-dark.png
• core/misc/configure.png
• core/misc/draggable.png
• core/misc/edit-active.png
• core/misc/edit.png
• core/misc/forum-icons.png
• core/misc/grippie.png
• core/misc/loading.gif
• core/misc/menu-expanded.png
• core/misc/menu-leaf.png
• core/misc/message-16-error.png
• core/misc/message-16-help.png
• core/misc/message-16-info.png
• core/misc/message-16-warning.png
• core/misc/message-24-error.png
• core/misc/message-24-help.png
• core/misc/message-24-info.png
• core/misc/message-24-ok.png
• core/misc/message-24-warning.png
• core/misc/permissions.png
• core/modules/forum/css/forum.module.css
• core/tests/Drupal/Tests/Core/Image/ImageTest.php

core/misc/grippie.png can be removed as the test in core/tests/Drupal/Tests/Core/Image/ImageTest.php is amended in this patch to point to misc/help.png instead.

The following files should not be removed for now as they are referenced in CSS or JS:

• core/misc/configure-dark.png
• core/misc/menu-expanded.png
• core/misc/message-16-error.png

So, attached patch keeps those files. The following files are deleted:

• core/misc/configure.png
• core/misc/draggable.png
• core/misc/edit-active.png
• core/misc/edit.png
• core/misc/forum-icons.png
• core/misc/grippie.png
• core/misc/loading.gif
• core/misc/menu-leaf.png
• core/misc/message-16-help.png
• core/misc/message-16-info.png
• core/misc/message-16-warning.png
• core/misc/message-24-error.png
• core/misc/message-24-help.png
• core/misc/message-24-info.png
• core/misc/message-24-ok.png
• core/misc/message-24-warning.png
• core/misc/permissions.png

1. For the files (sets) using an optional suffix, the grep needs to account for dynamic string concatenations as in the following (made up) example:

   $src = 'message-16-' . $message['type'] . '.png';
   

   E.g., like this:

   $ grep -r 'message-.*\.png' core/
   core/modules/filter/filter.api.php:  $image->setAttribute('src', base_path() . 'core/misc/message-16-error.png');
   core/modules/filter/filter.module:  $image->setAttribute('src', base_path() . 'core/misc/message-16-error.png');
   core/modules/filter/lib/Drupal/filter/Tests/FilterHtmlImageSecureTest.php:    $red_x_image = base_path() . 'core/misc/message-16-error.png';
   

   So that result is apparently correct; only message-16-error.png is used.

2. The same applies to files (sets) like configure[-dark].png, but in those cases, only the suffix might be dynamically removed via JavaScript, which means that the name configure.png may not necessarily appear in any grep results.

3. Specifically regarding configure[-dark].png, here the idea is that core uses -dark by default, but if a theme uses a dark/negated color scheme, then it can easily replace the referenced image in CSS to use the non-dark version (which works for negated color schemes). → configure.png is to be kept.

4. You can get a good summary of all images referenced in /misc:

   $ grep -r '\/misc' core/
   

5. Doing that apparently yields:

   core/modules/forum/css/forum.module.css:  background-image: url(../../../misc/forum-icons.png);
   

   ...but yet, that file is listed as unused and to be deleted in #34, so something went wrong again.

6. Likewise:

   core/tests/Drupal/Tests/Core/Image/ImageTest.php:    $source = __DIR__ . '/../../../../../misc/grippie.png';
   

7. Now, after looking at the patch, the last two mentioned points are addressed differently. Let's perform at least the forum-icons.png change in a separate issue (the patch for that should move/rename the existing file, instead of creating a new one).

I think #1356602-34: [META] Clean up icons in misc is almost perfect, but I agree that forum-icons.png should be move from core/misc to core/modules/forum/images, instead of deleting/creating new one.

I wonder whether we shouldn't split this entire issue into separate issues focusing on discrete image file-sets?

That allows for proper testing + screenshots of each individual aspect; e.g., to confirm that message icons still appear correctly, or that forum icons still work correctly, etc. — It's close to impossible to ensure that with the currently taken approach.

It would be good to at least clean this up a little before RC, I will try and create a few sub-issues soon.

This issue just keeps on giving. I've created three sub issues. Let's get them in and see how misc looks after then:
#2358675: Remove messages icons in misc
#2358683: Move forum icons into the forum module
#2358685: Remove edit and configure icons from misc

We should create a change record that covers all the child issues. See https://www.drupal.org/node/2358675#comment-9377411

I created some more child issues:
#2405057: Replace arrow-asc and arrow-desc images with Libricons and implement using CSS
#2405059: Replace menu images with Libricons
#2405061: Remove the unused permissions.png

This issue was originally committed in 8.x but then reverted and work was done in child issues. All the child issue but one are complete. Therefor, closing this meta as fixed.

Thanks all!

This does have a CR, removing tag.