I fiexed submit handlers

CommentFileSizeAuthor
fix_filtering.patch4.18 KBbenys
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Pasqualle’s picture

$form_state['values']['op'] == t('Filter')
checking the UI string value seems like a wrong pattern to me.. The developer should always use the code (id), not the display value.
so I prefer checking the $form_state['triggering_element']['#id'].
if the id is not unique, like the edit-filter vs edit-filter--2, then the id should be renamed to tt-filter or something..

otherwise the patch seems good..

benys’s picture

I thought the same, but I checked how it is done in other filter forms :-). http://api.drupal.org/api/drupal/modules--node--node.admin.inc/function/...

Pasqualle’s picture

@benys are you interested to becoming a co-maintainer?

benys’s picture

I am interested :-).
would be the first drupal's project where I will be cooworker :-)

Pasqualle’s picture

access granted, you can:
- push new code into the git repository
- assign issues to other maintainers

* Please do all the development in the issue queues, which means, create an issue before committing something into git. It is not obligatory to attach a patch to your issue, but if you start a bigger change we (maintainers) would like to know about it.
* If you need a new official release please create a new task. Dev releases are generated automatically (twice a day).
* If something is wrong or outdated on the project page, please create a new task.
* You can find me on IRC (freenode) #drupal-contribute, or send me an email through my contact form, and you will get my other contacts in reply.

Welcome on board, thank you for the help

dimitriseng’s picture

Hi. The patch is fixing the issue with the content types not being filtered. It also seems to provide the same behaviour as before for the rest of the types as far as I can see. I guess it is a question of choosing the prefered style.

One issue with the patch is that it removes the closing "*/* in the comments under the line "* Submit handler for the taxonomy translation form.", which is causing an issue.

Can you please confirm the prefered style and fix the issue with the closing comment? Thank you.

dimitriseng’s picture

The patch is working ok, any update on this? Please see my comments in #7, thank you.

Pasqualle’s picture

Category: task » bug
Status: Needs review » Fixed

this should be fixed in the next dev release

dimitriseng’s picture

I can confirm that this is working with the latest dev. Thank you Pasqualle!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.