The timeout constant is named "VARNISH_DEFAULT_TIMETOUT" - this should be "VARNISH_DEFAULT_TIMEOUT".

The timeout is used through 'socket_set_option':
socket_set_option($client, SOL_SOCKET, SO_SNDTIMEO, array('sec' => $seconds, 'usec' => $milliseconds));
socket_set_option uses 'usec' which is time in microseconds, not milliseconds. Although the values used in the module are correct, the variable name $milliseconds is potentially misleading to developers.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

manarth’s picture

Status: Active » Needs review
FileSize
1.78 KB
manarth’s picture

New patch: includes constant-name change in varnish.admin.inc as well.

fabsor’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.