Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The timeout constant is named "VARNISH_DEFAULT_TIMETOUT" - this should be "VARNISH_DEFAULT_TIMEOUT".
The timeout is used through 'socket_set_option':
socket_set_option($client, SOL_SOCKET, SO_SNDTIMEO, array('sec' => $seconds, 'usec' => $milliseconds));
socket_set_option uses 'usec' which is time in microseconds, not milliseconds. Although the values used in the module are correct, the variable name $milliseconds is potentially misleading to developers.
Comment | File | Size | Author |
---|---|---|---|
#2 | varnish-1360364-fix-typos-2.patch | 2.41 KB | manarth |
#1 | varnish-1360364-fix-typos.patch | 1.78 KB | manarth |
Comments
Comment #1
manarth CreditAttribution: manarth commentedComment #2
manarth CreditAttribution: manarth commentedNew patch: includes constant-name change in varnish.admin.inc as well.
Comment #3
fabsor CreditAttribution: fabsor commentedNice catch. Fixed here:
http://drupal.org/commitlog/commit/11214/1c40432b897deae0c9bdab1caa1848c...