These messages are sent to watchdog, so they are available to the admin and users with 'administer users' could just be confused by them (they appear to be errors when the account doesn't exist on the slave).

Patch to follow will simply remove them, but they could be hidden behind a variable as well ('Show Bakery debug messages' or something similar).

CommentFileSizeAuthor
#12 bakery-patch-ported-to-7x-1361548-12.patch888 byteszaporylie
#10 bakery-messageonlyforadmin-9209385-10.patch319 bytesmallezie
#6 bakery-slave-status-message-1361548-6-D6.patch1.03 KBbcmiller0
#5 bakery-control-slave-status-message-1361548-5.patch1.24 KBbcmiller0
#4 bakery-slave-status-message-1361548-4-D6.patch1.65 KBglennpratt
#4 bakery-control-slave-status-message-1361548-4.patch1.58 KBglennpratt
#1 bakery-remove-admin-dsm-1361548-1-D6.patch1.05 KBglennpratt
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

glennpratt’s picture

glennpratt CreditAttribution: glennpratt commented
FileSize
bakery-remove-admin-dsm-1361548-1-D6.patch1.05 KB

D6 patch.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented
Status: Active » Needs review

I think they are useful to be notified of them. Either way - better status.

coltrane’s picture

coltrane
he/him
CreditAttribution: coltrane commented
Status: Needs review » Needs work

How about leaving them for roles with permission 'administer bakery' ?

I don't think they should be removed entirely.

glennpratt’s picture

glennpratt CreditAttribution: glennpratt commented
Title: Remove admin specific drupal_set_messages » Change status drupal_set_messages to users with administer bakery.
Status: Needs work » Needs review
FileSize
bakery-control-slave-status-message-1361548-4.patch1.58 KB
bakery-slave-status-message-1361548-4-D6.patch1.65 KB

Makes sense to me.

7.x was missing the watchdog and a comment was out of place... I just made it like 6.x.

bcmiller0’s picture

bcmiller0 CreditAttribution: bcmiller0 commented
FileSize
bakery-control-slave-status-message-1361548-5.patch1.24 KB

re-rolled for d7 for alpha4 release to apply cleanly.

bcmiller0’s picture

bcmiller0 CreditAttribution: bcmiller0 commented
FileSize
bakery-slave-status-message-1361548-6-D6.patch1.03 KB

version d6 for alpha4, clean patch

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm commented
Version: 6.x-2.x-dev » 7.x-2.x-dev
Issue summary: View changes
Status: Needs review » Patch (to be ported)
Issue tags: +affects drupal.org

This needs to go into 7.x-2.x, as discovered at #2321431: Site functionality problem - New account holder receives Account Not Found message.

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm commented
Issue tags: +drupal.org hitlist
mallezie’s picture

mallezie
Primary language Dutch
Location Loenhout
CreditAttribution: mallezie commented
Assigned: Unassigned » mallezie

Let's try

mallezie’s picture

mallezie
Primary language Dutch
Location Loenhout
CreditAttribution: mallezie commented
Assigned: mallezie » Unassigned
Status: Patch (to be ported) » Needs review
FileSize
bakery-messageonlyforadmin-9209385-10.patch319 bytes

Could this be the right approach?

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm commented
Status: Needs review » Needs work

Not quite, the D6 approach was good and the same should be forward ported.

zaporylie’s picture

zaporylie
he/him
Primary language Polish
CreditAttribution: zaporylie commented
Status: Needs work » Needs review
FileSize
bakery-patch-ported-to-7x-1361548-12.patch888 bytes

Like this?

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm commented

Looks good. I haven't fully tested this, so I won't set it to RTBC quite yet.

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm commented
Issue tags: +needs drupal.org deployment
drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm commented
Status: Needs review » Reviewed & tested by the community

Looks good. I've added this to Drupal.org's build: https://bitbucket.org/drupalorg-infrastructure/drupal.org-sites-common/c...

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm commented
Issue tags: -needs drupal.org deployment
drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm at Drupal Association commented
Status: Reviewed & tested by the community » Fixed

Committed to 7.x.

  • drumm committed c6887a1 on 7.x-2.x authored by zaporylie 
    Issue #1361548 by zaporylie: Patch ported from 6.x to 7.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.