Hi:

This is the second fix (now as a patch). This time only fixing the node.tpl.php file. The fixes are:

* Remove commented code
* Correct indentation (using 2 characters and spaces)
* Remove trailing spaces
* Include $title_attributes in the H2 tag
* Other minor details

All the modifications are based on the Converting 6.x themes to 7.x and taking /modules/node/node.tpl.php as an starting point.

I don't think the links and comments rendering process at the end of the script should be that complex, but that will be another story :-)

Feel free to ask for anything

HTH

MyXelf

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

MyXelf’s picture

Status: Active » Needs review
FileSize
2.5 KB

Attaching the patch and changing the status...

Kisugi Ai’s picture

okay I have looked at it. ist commited in the devel
you can see

but I'm not sure about print and echo I think it' almost the same.
and the code like if () {} to if (): endif; well thats not realy an problem because its makes the same its only an another writingart.

and sorry I forgott to remove some of comments
I havnt test it on CentOS the demo pages runs under Deb. I know thats CentOS makes little trouble if its not all fine.
I have added the class=title in preprocess.
In the dev version I removed the things with the comment links

but look by your self I have not tested all at the moment

maybe the other themes we can change it too

MyXelf’s picture

Hi Alyx:

Thanks a lot for taking this into consideration. I was about to upload the 'block.tpl.php', the 'template.php' and the 'theme-settings.php'. I'll do it ASAP.

Yes, you are right, the print() and echo() are almost the same. That's the reason I replaced the 6 echo() with print() calls. Would be easier if you could run the code thru the Coder module, it will tell you a lot about the things that needs to be done in order to respect the Drupal coding standards. At some degree it is as you call it "writingart", but I think that's the highest achievement while writing a module (besides functionalities, of course). At the end you will gain in clarity, giving to others the chance of contribution.

I've been looking at the code of this theme since version 6.x and I would think it ten times before changing a comma. Now it is different.

I can't see the 7.x-2.x-dev version published. Am I missing something here?

Thanks again, this time, for your hard work. I know it shouldn't be easy.

MyXelf

MyXelf’s picture

I can see there is a mismatch in the version numbers. The recommended release is 7.x-2.2, and the development version is 7.x-1.x-dev. This will confuse people, I guess you should do something about this.

Kisugi Ai’s picture

of course its little miss machet because i have not set the branch ti 2x that was i have forgott to do thx for remember me ;)
yes its was hard work because i am a hobby programmer and php was almost totaly new for me and if you saw i have 5 theme projects and one active sandbox .
but slow down with the jung horses ;) i m very busy at the moment so i can't quickly answer you or commit some of code

with the braches i will trying to do at the weekend.

solong

MyXelf’s picture

No problem. I'm not expecting you to quickly do the commits or answer to any thread. But I'm trying to take advantage of this chance in my busy time (that won't last much more) and contribute to the theme. I was really surprised that you replied with such a hurry. Thanks for that, but I know that rhythm can't be kept. So take it easy and do as you please.

See you around

MyXelf

Kisugi Ai’s picture

Status: Needs review » Closed (fixed)

Is in the actual Dev in.