When I click "Album Contents" the table display breaks my layout. Is this normal? Is there an easy fix? Please see my file attachment for a sample.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mjohnq3’s picture

Same thing happens to my layout (standard Garland theme with Drupal 5.1) using either Firefox 2.0.x or IE 7.x. My screen resolution is 1024x768, but I'm not sure if that has anything to do with the problem. Because of this I have never been able to use Acidfree Albums.

vhmauery’s picture

Status: Active » Closed (works as designed)

That looks just like it does for me.

The problem is that there are thousands of things to put on the form and just not enough places to put them all. Personally, all I want on the form are the things in the first two columns. The third column is mostly just extra. But everybody and his dog wants his favorite other field on the form.

NancyDru’s picture

Well, actually, my dog could care less.

I pretty much only use that page to delete the entire album, so as far as I'm concerned, you can take stuff off.

mjohnq3’s picture

Oh well... never mind. Have a good day.

vhmauery’s picture

Status: Closed (works as designed) » Needs review
FileSize
13.14 KB

I have had a change of heart. Try out this patch. It does some fun stuff. First, it lets you choose which items to display (or all) and which columns they are shown in. On the acidfree settings page, you can choose which column to display stuff in. Then, on the album contents page, you will see that only the things selected to show up will be in the two columns. The rest (if the show all button is selected) will show up in a collapsible fieldset. If the all button is not selected, the other stuff will not show up at all.

Try it out to see if it breaks your layout (or if it breaks album contents). Does it delete things for you? Please give me some constructive feedback on this one. Do you see a better way to do this than I came up with?

vhmauery’s picture

Oh. I forgot. This patch renamed the acidfree settings function. So you might have to clear out your menu cache or you will get undefined function errors.

jaredwiltshire’s picture

This was kinda buggin me too so this patch sounds great.

I'll have to try it out.

How do you delete the menu cache? It would have to be done directly in the database right?

NancyDru’s picture

If you have the Devel module, that can do it. Otherwise, go to phpMyAdmin and Truncate the cache tables. You might also want to "Optimize" them after you're done to release the extra space.

vhmauery’s picture

hitting submit on the admin/build/modules page clears the cache as well (since it has to reload all the new modules' menu paths). But I always have a sql command line in the window next door.

mysql> truncate cache; truncate cache_filter; truncate cache_menu; truncate cache_page; truncate cache_views;

In my own testing, I have found that if you decide not to show the extras at all (so they don't get put in the collapsed fieldset) then videos get saved without their video files. So beware and don't test this on a production site. :)

foaad’s picture

FileSize
89.73 KB

Looks like I'm seeing the same thing.

When clicking on "Album Content" tab of an album, each node appears in two columns. The left column has the title, body and "album thumbnail" boxes, while the right column has the the usual drupal node settings like "Publishing settings", "Comment Settings", "Menu Settings", etc. The problem is that the left column is way too wide and as a result the right column is cut off and only about 1/3 of it is visible on my screen.

I'm using windows, tried IE6, and Firefox 2. My resolution is 1024x768 and my custom drupal theme is hard coded at 800 pixel width.

I used one of the supplied default themes (Marvin), and there, the right boxes are still cut off but I can scroll horizontally and see everything, but it's still clearly outside the bounds of what was intended for that theme.

Can you make this layout theme-dependent, or just list all the boxes vertically, so that they won't have to be next to each other and break the theme? Actually, if you point me to the right file, I could mess with the layout myself at least for my particular situation.

Thank You.

PS. Is your patch from earlier in this thread rolled into the June 23 release for Drupal 5.x?

vhmauery’s picture

The patch is not included yet because there are also some bug fixes in it that depend on some critical video module updates. I will commit the fix to this after the video fix has been committed, which hopefully will be soon.

foaad’s picture

I tried the patch. The initial problem was addressed, in that all boxes in "album content" were lined up vertically so I could at least access them. However,

  • All the content in all the configuration boxes were centered and looked ugly
  • the settings function/page could not be accessed, even after I flushed the cache by truncating the tables like your suggestion. It kept saying "argument 2" needs to be an array

So I could not use it as there was no way around the settings issue. Hope this helps.

albanetcsr’s picture

First of all, it's a great module. I guess it's impossible to please everyone, but I think the module stands out by offering nice out-of-the-box look, multiple upload and per-user albums functionality - even though the latter needs some work.

As far as the Album contents tab is concerned, IMO all it needs is an ability to group-delete pics, group-edit titles, bodies and (possibly) taxonomy.

I tried the patch but have not been able to get satisfactory results:
- The purpose of "Show all fields available in "Album Contents" view" checkbox is not clear as fields show up with it checked or unchecked. However, when unchecked, each album and image show up twice.
- Right column still appears to be beyond the screen (Garland). When all fields are in the left column, it looks more or less OK.

Other Album contents issues I saw:
- Body shows up for albums but does not show up for images. Maybe body is not created on mass import?
- In the per-user mode: Destination dropdown, Parent dropdown for albums and Acidfree albums taxonomy expose other people's albums

P.S. I don't know if it's possible but it would be really cool to let users code their own Acidfree tabs. It's a good module so no wonder everyone wants it to work their way.

rzsolt’s picture

I agree with the aboves, that this is a pretty nice album system, but the patch above would be very-very important. The current bloted Album Contents page is totally unusable for me: generally after a mass import I would like to edit only the titles of the new images, but with my limited drupal memory (24 MB) this is impossible if there are more than 5 pictures on a page. Please integrate this patch in the realease version as soon as possible. Thanks for your work.

Abilnet’s picture

Yes, integrating this patch would be highly appreciated. Thank you for the great module anyway!

mennonot’s picture

subscribing

mennonot’s picture

Addendum: I also noticed that the Album Content view does not display my SimpleMenu based drop down menu. Can someone with more expertise than me comment on whether this might be a related bug?

nexxer’s picture

subscribing

nexxer’s picture

Hello,

I tried the Album Contents patch. Very nice work, the columns work just fine in my limited testing. One thing, however, that stood out was that each entry now appears in duplicate. Each album and each photo appears in 2 rows.

Have others witnessed this or is it just me and a combination of other modules that makes it appear in my case?

Fanis

vhmauery’s picture

Status: Needs review » Fixed

This is fixed in the latest acidfree.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.