Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Crell’s picture

Status: Active » Needs review
andypost’s picture

Status: Needs review » Needs work
+++ sites/all/modules/cacheexclude/cacheexclude.module	(revision )
@@ -65,7 +65,7 @@
   if (!$_GET['q']) {
-    drupal_init_path();
+      drupal_path_initialize();
   }

I think this hunk is useless at all. because path gets initialized before hook_init() see _drupal_bootstrap_full()
I see no reasonable case for this code to be called and it's wrong because drupal_path_initialize() uses if (empty($_GET['q'])) {

Also there's a extra white-space in patch.

andypost’s picture

Status: Needs work » Needs review
FileSize
753 bytes

Bootstrap is changed in D7 so there's no DRUPAL_BOOTSTRAP_PATH phase so this hunk should be removed with comment for hook_init() implementation.

see drupal_bootstrap() D7 & _drupal_bootstrap() D6

rickmanelius’s picture

Status: Needs review » Reviewed & tested by the community

And drupal_path_initialize() is called in _drupal_bootstrap_full
http://api.drupal.org/api/drupal/includes%21common.inc/function/_drupal_...

I tested patch #3 against a custom URL pattern and it works as expected. Marking as RBTC.

Crell’s picture

Status: Reviewed & tested by the community » Fixed

Irony: I just finally got around to tagging a release for Drupal 6 that *adds* that check. Nice to know we can remove it in D7. :-)

Committed and pushed #3. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

Just a typo.