Support from Acquia helps fund testing for Drupal Acquia logo

Comments

e2thex’s picture

Status: Needs review » Needs work

The last submitted patch, 1369584-form-error-link-from-message-to-element.patch, failed testing.

mlncn’s picture

Version: 7.x-dev » 8.x-dev

Yes i know there are follow links now but this deserves the attention of a bump :-)

New features have to go into Drupal 8 first but i hope a backport to Drupal 7 is possible if it cannot be done in a module (perhaps in Form Messages, in progress).

e2thex’s picture

I have attach a patch that can apply to 7.15

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

lmeurs’s picture

Fix patch from #4 for Drupal 7 (tested on 7.43) so the prefix does not overwrite a possibly existing prefix + small code cleanup.

lmeurs’s picture

Sorry, wrong file, new file attached.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

robpowell’s picture

So I don't see this getting patched in d8 since the adoption of html 5 and aria support, 1174938. There was an attempt to backport that work to d7, 2984256 but is postponed until the regression which was introduced in 1174938 is resolved, 1797438. Unfortunately, this can be postponed till d9, so where does that leave us?

What this patch does is it makes the error messages link to the error fields. However when tabbing to the fields without using the link, there is no notification that the field has an error. In other words, a user using assistive technologies will not be alerted a specific field has an error as they tab through them. I believe this is one of the great short comings aria tags were supposed to solve. Since we don't have that option, I am going to suggest this gets RTBC.

Another possible path forward is using the https://www.drupal.org/project/clientside_validation module which has some support for aria based off this issue, 2940195

I attached a recording of running mac's voiceover with the patch installed.

robpowell’s picture

Version: 8.6.x-dev » 7.x-dev
Status: Needs work » Needs review
Issue tags: +Accessibility
Related issues: +#2984256: D7 Natively support the HTML5 required and aria-required FAPI properties