I can never remember the name of taxonomy_vocabulary_machine_name_load(). I always look up taxonomy_vocabulary_load() hoping there will be a @see reference, which there isn't. Eventually I left a comment to remind my future self about it. It seems to me it would be a good idea for each function to refer to the other.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jhodgdon’s picture

Issue tags: +Novice

Sounds reasonable. Just needs a patch -- probably good Novice project.

jvns’s picture

Status: Active » Needs review
FileSize
720 bytes
chris.leversuch’s picture

Status: Needs review » Needs work

I think @see should be at the end of the doc header

jvns’s picture

I thought so too, but everywhere elsewhere in taxonomy.module @see is before @param, so I went with that. Not clear to me what the right thing to do is. (fix it everywhere?)

jhodgdon’s picture

We're in the midst of cleaning up the Drupal 8 documentation so it conforms with our standards on this issue:
#1310084: [meta] API documentation cleanup sprint
The taxonomy module hasn't been done yet, and moving the @see to the end of the doc blocks is one of the cleanup tasks.

For this issue, please just do these functions right, and don't clean up the rest of the file. But if you're interested in cleaning up, you can join in the cleanup issue -- there are instructions there. :)

By the way, standards for how to do doc headers correctly are at:
http://drupal.org/node/1354

chris.leversuch’s picture

Status: Needs work » Needs review
FileSize
1000 bytes

New patch with @see at the bottom

xjm’s picture

This looks correct. Thanks!

xjm’s picture

Status: Needs review » Reviewed & tested by the community
webchick’s picture

Status: Reviewed & tested by the community » Fixed
Issue tags: +Needs backport to D7

Looks good! Committed and pushed to 8.x and 7.x. Thanks.

Automatically closed -- issue fixed for 2 weeks with no activity.