Once #375397: Make Node module optional gets in, we should remove Node.module form the minimal profile. User editable content is not always a desired feature, not does it prevent any WTFs, which is why Block or DBlog are part of the minimal profile.

CommentFileSizeAuthor
#7 remove-node-from-minimal-1370708-7.patch1.23 KBdagmar
#2 remove-node-from-minimal-1370708-2.patch962 bytesDevin Carlson
remove_node_from_minimal_00.patch391 bytesXano
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Status: Needs review » Needs work

The last submitted patch, remove_node_from_minimal_00.patch, failed testing.

Devin Carlson’s picture

Devin Carlson CreditAttribution: Devin Carlson commented
Component: rdf.module » profile.module
Status: Needs work » Needs review
FileSize
remove-node-from-minimal-1370708-2.patch962 bytes

Rerolled and changed variable_set('site_frontpage', 'node') to variable_set('site_frontpage', 'user').

Everett Zufelt’s picture

Everett Zufelt CreditAttribution: Everett Zufelt commented
Component: profile.module » install system

I'm pretty certain that profile.module refers to the Profile module.

Doesn't appear like there are components for the Core install profiles.

dman’s picture

dman CreditAttribution: dman commented
Issue tags: +DDU2012

Problem.
Applied patch (cleanly) onto clean checkout.
On running a new install (in a multisite) I got the following error at step "Install profile".

The installation has encountered an error.
Please continue to the error page

An AJAX HTTP error occurred. HTTP Result Code: 200 Debugging information follows. Path: http://minimal.drupal8.gadget/core/install.php?langcode=en&profile=minimal&id=1&op=do StatusText: OK ResponseText: User account | Drupal @import url("http://minimal.drupal8.gadget/core/modules/system/system.base.css?0"); @import url("http://minimal.drupal8.gadget/core/modules/system/system.theme.css?0"); @import url("http://minimal.drupal8.gadget/core/modules/field/theme/field.css?0"); @import url("http://minimal.drupal8.gadget/core/modules/user/user.css?0"); @import url("http://minimal.drupal8.gadget/core/modules/system/system.admin.css?0"); @import url("http://minimal.drupal8.gadget/core/modules/system/system.maintenance.css?0"); @import url("http://minimal.drupal8.gadget/core/themes/seven/reset.css?0"); @import url("http://minimal.drupal8.gadget/core/themes/seven/style.css?0"); User account Installation tasksChoose language(done)Choose profile(done)Verify requirements(done)Set up database(done)Install profile(active)Configure siteFinished SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'module' cannot be null

I'm reviewing now to isolate that this isn't a problem from my end or something odd, but right now it looks dodgy.

dman’s picture

dman CreditAttribution: dman commented
Status: Needs review » Needs work

Yeah, I can confirm this kills things.

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Priority: Minor » Normal
Issue tags: -DDU2012 +Framework Initiative, +Platform Initiative

I'd appreciate a re-roll against latest HEAD here. :) #4 should be obsolete by now.

dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
CreditAttribution: dagmar commented
Assigned: Xano » Unassigned
Status: Needs work » Needs review
FileSize
remove-node-from-minimal-1370708-7.patch1.23 KB

Re-rolled, and fixed issue mentioned in #4.

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Title: Remove Node from minimal profile » Remove Node module from Minimal installation profile
Issue tags: -Framework Initiative

This slightly conflicts with #1768758: Change default profile for tests from Testing to Minimal now, but I guess we can find a different solution for that issue.

However, to get buy-in from core committers here, I think we need a much better issue summary with solid arguments.

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Issue summary: View changes

Cleaned up argumentation.

alansaviolobo queued 7: remove-node-from-minimal-1370708-7.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 7: remove-node-from-minimal-1370708-7.patch, failed testing.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.