patch to support max number of images, max image size

These all sound like valuable features to me and I'd like to see them in imagefield. Some notes on your patch:

- Use t() to translate string:
Rather than 'The file you uploaded has a filesize greater than the maximum allowed filesize of '.$field['widget']['max_filesize'].'kb' use
t('The file you uploaded has a filesize greater than the maximum allowed filesize of @sizekb', array('@size' => $field['widget']['max_filesize']))

- Avoid duplicate code. Rather than including

        // add all new images saved in the session to the node_field
        if (is_array($_SESSION['imagefield'][$fieldname])) {
          foreach ($_SESSION['imagefield'][$fieldname] as $delta => $file) {
            $node_field[] = $file;
          }
        }

in two places in the same function, use an IF condition to skip the necessary code to get down to where this code already exists.

I put in a separate issue that adds mime-type validation (http://drupal.org/node/132054) which includes a seperate _validate function which you might consider as a cleaner way to accomplish the validation.

One more small thing, after uploading several images, if I upload a large one over the filesize it causes all images in the SESSION to not be displayed. Attempting to upload another image makes them all come back.

Oh dear I'm sorry I wasn't quite clear. Make one validation function and include all of the various validates in that one function. In the other patch I'm using _imagefield_widget_upload_validate().

Anyway, I don't think it matters much because both patches are going to need to be re-factored a little bit if they both go in. The rest of the patch looks okay.

@dopry Should this be an imagefield 2.0 feature or make it into the 1.2 release?

The 'max number of images' part seems a possible workaround for CCK's current inability to control the number of multiple values in a generic / all-field-types way.
One small remark, though : the error message ("You are only allowed to upload up to @maximages images") is misleading - you'd think this is a site-wide limit,
And I think the convention is to end error messages with a period.

Nitpicking, really...

Jaydub,

if you're up to a quick round of revision...

1) reroll for drupal-5--2, I'm not putting any new features into older branches.

2) move validation into _imagefield_widget_upload_validate

3) you can probably refector the max images to be something like count($node_field) + count($_SESSION['imagefield'][$fieldname])... if those aren't arrays in that validate function
something is probably wrong and we should figure out why they're not initialized instead of
testing if they're init'd before acting on them.

4) if you're using node_field, use items instead...

oops I forgot about the status update.

Subscribing...

I'd still love to see this land in imagefield after the 2.0 release. Any chance of re-rolling the patch jaydub?

Excellent, with one bug if editing a published node.

UPDATE: My mistake - just Excellent! Bug was not related to this patch (it was due to another fix elsewhere that I had applied shortly beforehand and didn't notice)

This patch looks great so far, but the for issue really needs to be addressed before I can commit it. I think we could set #disabled on the upload field and update the description text if items >= max images.

I wasn't talking about setting #disabled on any of the image rows for uploaded images... only on the new file upload element. This would force users to select an image to delete before uploading a new one.

The last patch you posted looks like it is reversed.

committed to DRUPAL-5--2 with modifications.