When the bean module is uninstalled, the blocks should also be deleted.

see #1351694: Check if bean type class exists when loading bean.

CommentFileSizeAuthor
#3 bean_clean-1376368-3.patch685 bytesindytechcook
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mrfelton’s picture

I'm not convinced about this. If you install, for example, webform module it creates a content type 'Webform'. You then create a load of webform nodes, and uninstall the module - it doesn't then delete al of the nodes that you had created. They just loose their type association and become something of broken/orphaned nodes.

Bean Blocks are being treated as content in most respects, so I would think it should follow the same mantra as node modules.

indytechcook’s picture

So it's a little different the the webform example. The webform adds a content type, not the content itself. If it was possible to disable the node module, would you want all of the nodes around?

Since uninstall the module will remove the bean table, we also need to remove the instances of the blocks. Otherwise it will get messy.

indytechcook’s picture

Status: Active » Needs review
FileSize
685 bytes

Attached Patch

saltednut’s picture

Status: Needs review » Needs work

patch: **** malformed patch at line 30: \ No newline at end of file

indytechcook’s picture

Automatically closed -- issue fixed for 2 weeks with no activity.