My site is set up to serve /admin pages as HTTPS. Admin Menu invokes favicon.ico as a HTTP file. User's browsers tell them that not all the content on the page is secure.

It would be helpful to serve up favicon.ico as a HTTPS link. Can anyone suggest a way to do this?

Thanks!

Ken

PS: the relevant code in admin_menu.inc is on lines 811ff ...

function theme_admin_menu_icon() {
  return '<img class="admin-menu-icon" src="' . (theme_get_setting('toggle_favicon') ? theme_get_setting('favicon') : base_path() . 'misc/favicon.ico') . '" width="16" height="16" alt="' . t('Home') . '" />';
}

Is there are a way to convert the absolute URL into a relative URL?

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sun’s picture

Title: Admin Menu calls up favicon.ico as a HTTP link on a HTTPS page » Cached icon breaks HTTPS pages
Version: 7.x-3.0-rc1 » 7.x-3.x-dev
Component: Miscellaneous » Code
Category: support » bug
Status: Active » Needs review
Issue tags: +API change
FileSize
1.76 KB

Glad I found this issue before doing the stable release, as the fix requires an API change.

Attached patch resolves this issue.

sun’s picture

Status: Needs review » Fixed

Thanks for reporting, reviewing, and testing! Committed to all branches.

A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

jean-baptiste’s picture

Backport of this patch for D6 (tested on admin_menu 6.x-1.8)

mvc’s picture

Issue summary: View changes
FileSize
752 bytes

thanks, @jean-baptiste -- i rerolled the patch in #4 above as properly formatted patch for use with drush_make