Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
My site is set up to serve /admin pages as HTTPS. Admin Menu invokes favicon.ico as a HTTP file. User's browsers tell them that not all the content on the page is secure.
It would be helpful to serve up favicon.ico as a HTTPS link. Can anyone suggest a way to do this?
Thanks!
Ken
PS: the relevant code in admin_menu.inc is on lines 811ff ...
function theme_admin_menu_icon() {
return '<img class="admin-menu-icon" src="' . (theme_get_setting('toggle_favicon') ? theme_get_setting('favicon') : base_path() . 'misc/favicon.ico') . '" width="16" height="16" alt="' . t('Home') . '" />';
}
Is there are a way to convert the absolute URL into a relative URL?
Comment | File | Size | Author |
---|---|---|---|
#5 | admin_menu-1376852-5-cached-icon-breaks-https-pages.patch | 752 bytes | mvc |
#1 | admin_menu.icon-https.1.patch | 1.76 KB | sun |
Comments
Comment #1
sunGlad I found this issue before doing the stable release, as the fix requires an API change.
Attached patch resolves this issue.
Comment #2
sunThanks for reporting, reviewing, and testing! Committed to all branches.
A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.
Comment #4
jean-baptiste CreditAttribution: jean-baptiste commentedBackport of this patch for D6 (tested on admin_menu 6.x-1.8)
Comment #5
mvcthanks, @jean-baptiste -- i rerolled the patch in #4 above as properly formatted patch for use with drush_make