Token integration was added in the (now) v2 branch but as that code branch is a bit of a clusterfsck I don't want to continue it. Instead, I'd like to cleanly re-implement token integration in the v1 branch.

Files: 
CommentFileSizeAuthor
#25 nodewords-6.x-1.14-patch-Tokens.zip77.59 KBaiphes
#20 TokenSupport-1380362-20.patch9.95 KBmrP
PASSED: [[SimpleTest]]: [MySQL] 127 pass(es).
[ View ]
#21 BasicTokenSupport-1380362-21.patch9.95 KBmrP
PASSED: [[SimpleTest]]: [MySQL] 127 pass(es).
[ View ]

Comments

Hi Damien,

Are tokens already usable in the new (and awesome) 1.13 version?

All the best!

@AlfTheCat: no, there's no Token support in the new release, unless you do so yourself via the hooks. Hopefully for the next release.

Will this include Open Graph token support?

@bjalford: It'll be possible to use tokens in Open Graph tags, is that what you mean?

yes - thanks

I've added the following note to the README.txt and project page:

  • Nodewords currently does not support tokens, that functionality was lost when the 6.x-1.12-x codebase was reverted. Adding Token support is planned for a future release: http://drupal.org/node/1380362

Version:6.x-1.x-dev» 6.x-2.x-dev

Decided to bump this to the v2 branch, which will be rebuilt from the current v1 codebase.

I think the use of tokens was the only meaning of this module. How can I go back to version 1.11?
With 1.13 all my pages became completely stupid to look in the search results.

You would have to go back to one of the v1.12 betas, but they had problems too.

Any update about token integration? In my opinion, not having tokens working makes this module almost counter productive as Google will punish your site for having identical meta descriptions on every page.

Status:Active» Postponed

Marking all v2 issues as postponed while v1 is finished off.

I haven't surfed the code yet, but I would ask to reconsider adding token to v1. It shouldn't really be any hard to implement, it's just properly adding a couple of token replace functions before outputting the tags, or am I missing something? I am willing to try to submit a patch if this might be considered.

@hanoii: I'll happily review a patch. My concern with tokens is that when you check empty($tag['value']) it will find the token string, not its output, so the current logic of using defaults if the overrides are empty will require more processing.

this would only happen if the override has a token that expands to an empty string?

You could always check for empty after the replacement of tokens have happened.

hanoii, are you still working on a patch? I'll gladly review it.

Version:6.x-2.x-dev» 6.x-1.14-beta2

Hello, after a long time of putting off "upgrading" from the 1.2 (or 2.x) release as it was working great for me, I finally did so yesterday (mostly due to the annoying error always notifying me that my release was no longer supported).

I have to comment though, I was disappointed to find that token support was removed from the module. I have to agree with what others have already mentioned, this was certainly one of the primary components to having this module to begin with. If I wanted the same default meta info on every page I would simply hard code it, however as also previously mentioned, search engine penalize for having it as such.

I think that if this is going to be a feature request that it needs to be so under the 1.4 branch as this seems to be the current version in development. and as the 1.2 or rather 2.x version already has token support... I would personally say that this is a pretty vital feature for this module and hope @maintainers find it to be as well and choose to change this to active again soon.

If attention gets put into this re-implementation soon I would definitely be on board to help and test it for bugs. Thanks for all the work put into this module!

yet another +1 for reimplementing token support, and very willing to contribute with bounty and testing.

ps: if token is nasty and requires lots of work, at least would be useful to be able to use the default 'page title' together with 'site name divider' text. This and custom pages meta tags paths can handle quite a few combinations.

I believe page title and site name is the standard default

@hanoii: the problem is that 'site name divider' works only if you first specify a 'page title', so this makes custom pages paths almost unusable.

As it is now, if you specify:

PATH: countries/*
PAGE TITLE:
SITE NAME DIVIDER: holidays and vacations |

does not "take" and nothing happens on your countries/* pages. To make it work you need to specify 'page title' also, for example:

PATH: countries/*
PAGE TITLE: Foo
SITE NAME DIVIDER: holidays and vacations |

but this outputs "Foo holidays and vacations | Sitename" on all countries/* pages, which is no good both for usability and SEO.

Unless i am missing something...

Status:Needs review» Needs work
StatusFileSize
new9.95 KB
PASSED: [[SimpleTest]]: [MySQL] 127 pass(es).
[ View ]

The patch adds token support to nodewords_basic for description, abstract, keywords, and copyright only. The available tokens are quite limited (ie, no taxonomy, vocabulary, body, or teaser tokens) though adding the others present in the old 2.x version should be pretty straighforward.

Its probably junk, but at least its a start.

Priority:Normal» Major
Status:Postponed» Needs review
StatusFileSize
new9.95 KB
PASSED: [[SimpleTest]]: [MySQL] 127 pass(es).
[ View ]

...testbot please (but still needs work *obviously*)

Version:6.x-1.14-beta2» 6.x-1.x-dev

Changing the status so it doesn't get overlooked.

patch work on 1.14 version...but missing token like node-teaser..

Also missing token arg[0], arg[1] etc for arguments of the url tokens. These are very important to me

@aiphes can you winzip your version including tokens, I am not able to get it to work..sorry.

greetings, Martijn

StatusFileSize
new77.59 KB

here it is

Hi, Aiphes,

Did you add url tokens like arg[0] etc...or are you willing to?

greetings, Martijn

i did just apply the patch #21

why token isn't added in function nodewords_basic_title_prepare ?

I can confirm that I just applied patch #21 to the latest dev version, and I now have token support, which meets my requirements.

Hello,

Is the integration of this feature/patch in the roadmap of nodewords ?
Is there any plans to extend this feature/patch to submodules like OPen Graph ?