I suggest to split current huge theme function theme_field_slideshow() into more specific theme functions or even use template file for theming. Currently, any small customization requires creating the copy of the whole theme_field_slideshow() function.

Comments

jdanthinne’s picture

Status: Active » Needs review

Hi,
I've just pushed changes to the DEV version.
The module is now using a template file (it took me some time because it's the first time I do that).
Please try next DEV release and tell me what you think of it…

Steven Jones’s picture

Status: Needs review » Needs work

This is great, but it would be ever more helpful if you were to split the preprocess function into a process function too. I'll work on a patch.

Steven Jones’s picture

Actually, I'm probably not going to have time to work on this sorry, but actually I think you can just change a lot of the calls to the theme function in the preprocessor into render arrays, and then use the render function in the template file, and then people will be able to modify the image cleanly if they need to.

jdanthinne’s picture

@Steven Jones : I'm not used to use the new render function. Do you have a nice url with tutorial on that?

Steven Jones’s picture

Not that I can think of, sorry! Maybe the Examples project has something?

jdanthinne’s picture

I've just ordered the Drupal 7 Module Development last week, there should be something about that in it :-)