It should be "References dialog" instead of "References Dialog" (no capital "d" in "dialog"). Please see here why: #1103208: Projects' names should be checked in .info files for correct capitalization.

Don't forget the project's name here on d.o too ;)

CommentFileSizeAuthor
#11 1390706-capitalize-first-letters-11.patch1.22 KBanoopsingh92
#8 1390706-capitalize-first-letters.patch23.06 KBanoopsingh92

Issue fork references_dialog-1390706

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

fabsor’s picture

fabsor CreditAttribution: fabsor commented
Status: Active » Fixed

Fixed here:

http://drupal.org/commitlog/commit/23918/6601361aefb120411105618dc3254b7...

Thanks for noticing!

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
CreditAttribution: klonos commented

...no problem Fabian. Thanx for this very useful project and the time and effort you put in it.

...though I see that you are involved in a bunch of other projects that don't follow the naming standard. I guess that changing all their names in order to conform to the standard would be a really tedious job. Just remember it as you work on them in the future and correct along the way ;)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Michelle’s picture

Michelle
she/her
Primary language English
Location Wisconsin, USA
CreditAttribution: Michelle commented

See #1346158: Decide on coding standard for capitalization of module names [policy, no patch] and #1430452: Use Proper Name Case for core modules for current information on this policy.

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
CreditAttribution: klonos commented
Title: Do not capitalize first letters in References dialog project's name. » Capitalize first letters in References Dialog project's name.
Status: Closed (fixed) » Active

...yep, the standard has changed and it now allows (more likely suggests) Proper Name Case instead of the Sentence case for module/theme names. The Sentence case policy remains for UI text like widget labels for example.

anoopsingh92’s picture

anoopsingh92
Location Rajasthan, India
CreditAttribution: anoopsingh92 at Valuebound for Valuebound commented
Issue summary: View changes

Hi,

I am working on this.

Thanks

anoopsingh92’s picture

anoopsingh92
Location Rajasthan, India
CreditAttribution: anoopsingh92 at Valuebound for Valuebound commented
Assigned: Unassigned » anoopsingh92
anoopsingh92’s picture

anoopsingh92
Location Rajasthan, India
CreditAttribution: anoopsingh92 at Valuebound for Valuebound commented
FileSize
1390706-capitalize-first-letters.patch23.06 KB

Hello,

I have fixed some issues. Please review this patch.

Thanks

Michelle’s picture

Michelle
she/her
Primary language English
Location Wisconsin, USA
CreditAttribution: Michelle at Mediacurrent commented
Issue tags: -do not capitalize name

@anoopsingh92 Your patch doesn't seem to be related to this issue. Did you post it in the wrong place?

anoopsingh92’s picture

anoopsingh92
Location Rajasthan, India
CreditAttribution: anoopsingh92 at Valuebound for Valuebound commented

Thank you @Michelle for review the patch. I will check this patch once again and update you soon.

Thank you

anoopsingh92’s picture

anoopsingh92
Location Rajasthan, India
CreditAttribution: anoopsingh92 at Valuebound for Valuebound commented
Assigned: anoopsingh92 » Unassigned
Status: Active » Needs review
FileSize
1390706-capitalize-first-letters-11.patch1.22 KB

Hello,
I have updated the patch please review.

Thanks

Michelle’s picture

Michelle
she/her
Primary language English
Location Wisconsin, USA
CreditAttribution: Michelle at Mediacurrent commented

@anoopsingh92 - That's doing the opposite of what it should. Which means this issue must already be fixed aside from capitalizing the D on the project page.