Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
aspilicious pointed this out in #1062240-13: Recognize date fields from entities that are not the same as the view's base type, but the field name was still using underscores.
Taking advantage of this to just add it to fullcalendar_fullcalendar_classes.
Comment | File | Size | Author |
---|---|---|---|
#7 | fullcalendar-1390796-7.patch | 1.7 KB | tim.plunkett |
#5 | 1390796-4-version2.patch | 2.89 KB | aspilicious |
#4 | 1390796-3-version1.patch | 1.72 KB | aspilicious |
#4 | 1390796-3-version2.patch | 2.89 KB | aspilicious |
#1 | fullcalendar-1390796-1.patch | 1.36 KB | tim.plunkett |
Comments
Comment #1
tim.plunkettSee attached.
Comment #2
aspilicious CreditAttribution: aspilicious commentedThis is not a correct fix. I maybe didn't make the problem clear.
It's not about the date field it is about the classes in general.
In fact we just need to add the date field class to the classes array and clean the array up afterwards.
So only doing the drupal_html_id once.
We provide hooks for adding classes, those classes can be colored if some adds an _ to it's classname it gets converted to - in ctools css. So it is our job to do the same when it comes to classes.
The problem with fieldgroup:
- classname: node-type-field_group
- css name: node-type-field-group
I'm going to work on a patch
Comment #3
tim.plunkettOh I see. Still, don't use drupal_html_id, use drupal_html_class. There is a big difference and we definitely don't want _id
Comment #4
aspilicious CreditAttribution: aspilicious commentedTwo patches. Both contain a proper fix but one uses a seperate function. I like the second version the most.
Yeah drupal_html_id is bad I didn't knew about drupal_html_class and after reading the docs and the function I noticed the id version adds extra stuff to the name if they are duplicated.
Comment #5
aspilicious CreditAttribution: aspilicious commentedVersion 2 without tab problems...
Comment #6
aspilicious CreditAttribution: aspilicious commentedNote: I think the intendation is wrong in the prepare function.
Comment #7
tim.plunkettAfter discussion on IRC, a new patch!
Comment #8
tim.plunkettAwesome. http://drupalcode.org/project/fullcalendar.git/commit/9120471