For example, if I set under "User platforms" for users to be able to have Facebook, Google+ and LinkedIn then each and every user must enter all of those in order to save their settings. If they don't they get the form errors.

It is unrealistic to expect every user to have all of the types of social accounts that an admin. makes available to them.

In the case above here are the errors I got when I only had a FaceBook account to enter:

  LinkedIn URL invalid.
  Google+ URL invalid.
CommentFileSizeAuthor
#14 Screen Shot 2012-05-09 at 1.54.22 PM.png51.35 KBbjlewis2
#14 Screen Shot 2012-05-09 at 1.55.43 PM.png42.12 KBbjlewis2
#7 socialmedia.platforms.inc_.patch7.93 KBpverrier
#6 socialmedia.platforms.inc3_.patch7.76 KBReg
#2 socialmedia.platforms.inc2_.patch7.86 KBReg
#1 socialmedia.platforms.inc_.patch3.56 KBReg
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Reg’s picture

Reg CreditAttribution: Reg commented
FileSize
socialmedia.platforms.inc_.patch3.56 KB

Here is a quick patch to get around this. I must admit in this case this one was a "quick and dirty" and only meant as a short term solution for whomever needs something now. Please don't take it as any sort of a "solid" fix, I didn't look closely enough at the code for that.

Reg’s picture

Reg CreditAttribution: Reg commented
FileSize
socialmedia.platforms.inc2_.patch7.86 KB

The one above produced some token errors. This one has those fixed (at least the ones I found.)

What I'm not sure how to do with a quick look is how to make the widgets that have blank data not show up so that you only see the widgets for which each user actually has a social account. If someone could add a patch for that it would terrific.

SocialNicheGuru’s picture

SocialNicheGuru CreditAttribution: SocialNicheGuru commented

patch doesn't apply cleanly.

git apply s*patch
error: www/cms/sites/all/modules/socialmedia/socialmedia.platforms.inc: No such file or directory

i think it should be
a/socialmedia/socialmedia.platforms.inc
b/socialmedia/socialmedia.platforms.inc

Reg’s picture

Reg CreditAttribution: Reg commented
FileSize
socialmedia.platforms.inc3_.patch7.76 KB

I manually edited the patch to the paths you suggested. It also might meant to be something like:

a/sites/all/socialmedia/socialmedia.platforms.inc
b/sites/all//socialmedia/socialmedia.platforms.inc

or

a/socialmedia.platforms.inc
b/socialmedia.platforms.inc .

I have a more complicated than usual site structure with a multi-site installation and a lot of customization so I can't really reliably test a typical installation. Please try it now and if it doesn't work feel free to adjust the paths and then upload what works. Unless line three has some sort of hidden checksum built into it (which I doubt) it's only lines 1, 3 & 4 you need to change.

pverrier’s picture

pverrier CreditAttribution: pverrier commented
FileSize
socialmedia.platforms.inc_.patch7.93 KB

Here's the patch for the current beta9 version of socialmedia.platforms.inc ; I've also modified the quantifiers for the regex making 'www.' optional (* used instead of ?).

MrPaulDriver’s picture

MrPaulDriver CreditAttribution: MrPaulDriver commented

This problem persists in Beta 11.

Is there any sign of a proper fix for this yet?

dddave’s picture

dddave CreditAttribution: dddave commented
Version: 7.x-1.0-beta5 » 7.x-1.0-beta11
Status: Active » Needs review

Test if the patch applies and works and report back. That might speed things up...

MrPaulDriver’s picture

MrPaulDriver CreditAttribution: MrPaulDriver commented

sorry, but I'm not up to speed on patching, Hopefully someone else can test.

dddave’s picture

dddave CreditAttribution: dddave commented

Very good tutorial about applying patches: http://drupal.org/node/620014

MrPaulDriver’s picture

MrPaulDriver CreditAttribution: MrPaulDriver commented

Thanks dddave, I'll give it a go.

Do you mean the same patch at #7?

dddave’s picture

dddave CreditAttribution: dddave commented

yup.

bjlewis2’s picture

bjlewis2 CreditAttribution: bjlewis2 commented
Status: Needs review » Reviewed & tested by the community
FileSize
Screen Shot 2012-05-09 at 1.55.43 PM.png42.12 KB
Screen Shot 2012-05-09 at 1.54.22 PM.png51.35 KB

Works like a charm for allowing users to only enter the profiles they want.

However, any profiles not filled out still show, but just link to their profile on the site. Here are some pictures explaining what I mean:
The only profiles I filled in are Twitter and Facebook. I left everything else empty

All of the icons show. The empty ones link to my site profile page.

Can we update this so that only the filled in profiles are displayed?

Reg’s picture

Reg CreditAttribution: Reg commented

Agreed, it's a problem. When I submitted the original patch I mentioned that (comment). I was hoping someone who knew the module better would have a fix for that one.

dddave’s picture

dddave CreditAttribution: dddave commented
Status: Reviewed & tested by the community » Needs work
chrowe’s picture

chrowe CreditAttribution: chrowe commented

patch in #7 worked for me

CPJS’s picture

CPJS CreditAttribution: CPJS commented

Problem still there, in beta 11.

mrweiner’s picture

mrweiner CreditAttribution: mrweiner commented
Priority: Normal » Major

Agreed, still present in beta 11. Changing priority to major, as I feel this compromises the main functionality of this portion of the module. I was going to leave it as normal, until I realized that this bug has been a posted issue since the beginning of the year. Hopefully this gets the maintainers of the module to realize the problem is a very important issue, instead of users attempting (and doing a great job so far, don't get me wrong) to incompletely patch up the problem.

Maintainers, thank you very much for the module, but please fix this.

Reg’s picture

Reg CreditAttribution: Reg commented

Agreed, at this point it's either apply user patches or simply not use it. In my case I am just not upgrading when the new betas come out so I don't have to redo the patches.

brentratliff’s picture

brentratliff CreditAttribution: brentratliff commented

I'm going to have to disable this module or come up with a patch if it's mandatory to fill in all profiles and/or they all display regardless of whether or not they are active. I agree this is a major release blocker that goes to the very core of the module. Is there any chance of getting the patch in #7 committed to dev while working on the widget display as a separate issue? I'm willing to take stab at the display issue after I get a chance to read the code.

mrweiner’s picture

mrweiner CreditAttribution: mrweiner commented

This module was one of many that I tried when first trying to find a module to add social networks. Honestly, it was probably the worst, for this issue alone. I don't really remember what this module did that seemed so special, but I have since moved to using the Follow module instead. I haven't looked back for a second. If the maintainers don't care about this module, then why should we?

brentratliff’s picture

brentratliff CreditAttribution: brentratliff commented

I'm also now using the Follow module successfully. I will say as a module maintainer though, that I understand priorities of developers change and they probably have other pressing issues to take care of first. I know my modules could use some love.

mrweiner’s picture

mrweiner CreditAttribution: mrweiner commented

It's not so much that there may be other problems that the developer needs to take care of. That, I completely understand. It's more of the fact that it has been an issue for 7 months, and a major issue for a month, and there's been no response from the maintainer. Especially since this module is "sponsored and developed" by a company, I at least expect a response saying that priorities have changed and that this module unfortunately won't receive the required updates until something changes. I don't know, maybe it's just me. Either way, it's probably unproductive to continue discussion about my beliefs on maintainer commitment. I just hope that something can be done about this issue for those who want to continue using it. :)

Reg’s picture

Reg CreditAttribution: Reg commented

Personally I considered this critical when I raised this issue. I disable the user part of the module because for any number of users greater than one it's pretty much unusable.

TomDude48’s picture

TomDude48 CreditAttribution: TomDude48 commented
Status: Needs work » Needs review

The requirement has been removed in the latest push.