Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Just saw that this module is dealing with lots of strings around this variable and I'm sure that this variable as type boolean will do a great job. A patch for that is attached together with setting the default during installation to FALSE.
Comment | File | Size | Author |
---|---|---|---|
#2 | make_variable-1391926-2.patch | 4.53 KB | jurgenhaas |
aes.patch | 3.37 KB | jurgenhaas |
Comments
Comment #1
dpovshed CreditAttribution: dpovshed commentedTotally agree about your idea, but I have feeling the code fragments like
if (variable_get("aes_convert", FALSE)) {
will compromise users who have currently stored aes_convert as a string, just because string is TRUE when casted to bool.
So if we need change to be applied would be nice to:
- add update_hook_N;
- reformat according to coding standard.
Comment #2
jurgenhaasAgreed, the rewritten and extended patch is attached.
Comment #3
dpovshed CreditAttribution: dpovshed commentedRevieved, tested and committed to dev without any changes. Thanks Jürgen!