_filter_xss_attributes is a bit hard to read because things aren't setup at the top but in the middle of the code.

This patch adds a sane default value for $skip.

Files: 
CommentFileSizeAuthor
#10 xss-skip-default-1398044-10.patch481 bytesbradwade
PASSED: [[SimpleTest]]: [MySQL] 55,632 pass(es).
[ View ]
#3 drupal-skip_default-1398044-3.patch481 bytesiStryker
PASSED: [[SimpleTest]]: [MySQL] 55,955 pass(es).
[ View ]
#1 1398044-skip-default.patch371 bytesdawehner
PASSED: [[SimpleTest]]: [MySQL] 34,594 pass(es).
[ View ]

Comments

Status:Active» Needs review
StatusFileSize
new371 bytes
PASSED: [[SimpleTest]]: [MySQL] 34,594 pass(es).
[ View ]

So here is the patch, it's definitive really minor.

Status:Needs review» Reviewed & tested by the community

This is a very old patch.

> git apply -v --index 1398044-skip-default.patch
Checking patch core/includes/common.inc...
Hunk #1 succeeded at 1124 (offset -334 lines).
Applied patch core/includes/common.inc cleanly.

Patch is good and doesn't break anything.

Title:Provide default value for $skip in _filter_xss_attributesProvide default value for $skip in XSS Component
Status:Reviewed & tested by the community» Needs review
Issue tags:+Novice
StatusFileSize
new481 bytes
PASSED: [[SimpleTest]]: [MySQL] 55,955 pass(es).
[ View ]

May 28th, #1998466: Convert filter_xss_admin and similar function to an Xss component was committed which broke this patch. Re-rolling...

Status:Needs review» Reviewed & tested by the community

Cool.

Status:Reviewed & tested by the community» Needs work
Issue tags:-Novice

The last submitted patch, drupal-skip_default-1398044-3.patch, failed testing.

Status:Needs work» Needs review

#3: drupal-skip_default-1398044-3.patch queued for re-testing.

Status:Needs review» Needs work

The last submitted patch, drupal-skip_default-1398044-3.patch, failed testing.

Status:Needs work» Needs review
Issue tags:+Novice

#3: drupal-skip_default-1398044-3.patch queued for re-testing.

Assigned:Unassigned» bradwade

Will reroll

StatusFileSize
new481 bytes
PASSED: [[SimpleTest]]: [MySQL] 55,632 pass(es).
[ View ]

Rerolled #3

Status:Needs review» Reviewed & tested by the community

+1

Category:feature» task
Status:Reviewed & tested by the community» Fixed

Looks good to me. Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.