JW Player using Video module thumbnails [#1398390]

Comment	File	Size	Author
	video_thumbs-1.patch	1.13 KB	Dippers

Comment #1

Dippers CreditAttribution: Dippers commented 9 January 2012 at 09:02

Comment removed

Log in or register to post comments

Comment #2

rickvug CreditAttribution: rickvug commented 11 January 2012 at 14:19

Status:

Needs review

» Postponed

Thank you for the patch Dippers. Before implementing support for images provided by Video module I'd like to have a pluggable system to work out where the preview image (ie. "poster") should come from. See #1395584: Provide image poster (with configuration to select the source) for the issue. For the moment I have updated the tpl file to use a poster, should one exist. Other modules can step into the preprocess stage as needed so it could even be possible to implement this in video if one wanted.

For now I'm going to call this postponed until there's a patch and way forward at #1395584: Provide image poster (with configuration to select the source). I'd be happy to have your input and patches to drive the effort forward.

Log in or register to post comments

Comment #3

andypost

he/him

Russian

CreditAttribution: andypost commented 14 February 2012 at 00:03

Suppose "pluggin-way" for this is a useless complexity. I think better to implement a few alter|preprocess functions to provide integration for core, file entity and video modules

Log in or register to post comments

Comment #4

rickvug CreditAttribution: rickvug commented 14 February 2012 at 12:03

@andypost I think you may be right that implementing (or providing) hooks may be a simpler and easier way to get this done.

Log in or register to post comments

Comment #5

andypost

he/him

Russian

CreditAttribution: andypost commented 19 February 2012 at 14:51

@rickvug Video module now supports Jw player
So you can update the module page about it

TODO
- update docs about using poster image see #1398388-2: Using JW Player
- probably implement a variable with default preset to be used in this kind of integrations (currently custom module should load preset because presets are loaded in the module preprocess

Log in or register to post comments

Comment #6

tokonowaka CreditAttribution: tokonowaka commented 1 December 2012 at 16:44

function mymodule_preprocess_jw_player(&$variables) {
	if(isset($variables['file_object']->thumbnailfile)) $variables['config']['image'] = file_create_url($variables['file_object']->thumbnailfile->uri);
}

this works for me.